From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"Jeff Cody" <jcody@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org, peterx@redhat.com,
dgilbert@redhat.com,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
mrezanin@redhat.com, jsnow@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 2/3] block-jobs: Optionally unregister live block operations
Date: Thu, 31 Aug 2017 08:45:40 +0200 [thread overview]
Message-ID: <877exki6az.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <4f2efa42-4a81-9890-497f-123c2b9a946c@redhat.com> (Eric Blake's message of "Wed, 30 Aug 2017 14:23:33 -0500")
Eric Blake <eblake@redhat.com> writes:
> On 08/30/2017 12:24 PM, Eduardo Habkost wrote:
>> On Wed, Aug 30, 2017 at 01:01:41PM -0400, Jeff Cody wrote:
>>> From: Jeffrey Cody <jcody@redhat.com>
>>>
>>> If configured without live block operations enabled, unregister the
>>> live block operation commands.
>>>
>>> Signed-off-by: Jeff Cody <jcody@redhat.com>
>>> ---
>>> monitor.c | 16 ++++++++++++++++
>>> 1 file changed, 16 insertions(+)
>>>
>
>>
>> I suggest using the new mechanisms added by:
>>
>> [PATCH 00/26] qapi: add #if pre-processor conditions to generated code
>
> Those haven't landed yet, but as both series are proposed for 2.11, I
> indeed agree that basing this series on top of that one will be a bit
> cleaner.
Rebasing shouldn't be hard. However, we then have to hold it until the
QAPI series lands. I don't think holding is necessary, as the conflicts
between the two are obvious, and should be straightforward to resolve.
next prev parent reply other threads:[~2017-08-31 6:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 17:01 [Qemu-devel] [PATCH v2 0/3] Live block optional disable Jeff Cody
2017-08-30 17:01 ` [Qemu-devel] [PATCH v2 1/3] configure: Add option in configure to disable live block ops Jeff Cody
2017-08-30 17:01 ` [Qemu-devel] [PATCH v2 2/3] block-jobs: Optionally unregister live block operations Jeff Cody
2017-08-30 17:24 ` Eduardo Habkost
2017-08-30 19:23 ` Eric Blake
2017-08-31 6:45 ` Markus Armbruster [this message]
2017-09-06 13:00 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2017-09-06 15:02 ` Eduardo Habkost
2017-09-06 16:42 ` Eric Blake
2017-08-30 17:01 ` [Qemu-devel] [PATCH v2 3/3] hmp: Optionally disable live block operations in HMP monitor Jeff Cody
2017-09-05 14:01 ` Dr. David Alan Gilbert
2017-08-30 19:17 ` [Qemu-devel] [PATCH v2 0/3] Live block optional disable Eric Blake
2017-08-30 19:26 ` Eric Blake
2017-09-06 12:58 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877exki6az.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mrezanin@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.