From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH RESEND v4 1/6] drm/i915: Add DPCD preferred mode for backlight control Date: Wed, 03 May 2017 12:11:53 +0300 Message-ID: <877f1yqp7q.fsf@intel.com> References: <20170418234824.157355-1-puthik@chromium.org> <20170418234824.157355-2-puthik@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 822096E2D9 for ; Wed, 3 May 2017 09:09:30 +0000 (UTC) In-Reply-To: <20170418234824.157355-2-puthik@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Puthikorn Voravootivat List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAxOCBBcHIgMjAxNywgUHV0aGlrb3JuIFZvcmF2b290aXZhdCA8cHV0aGlrQGNocm9t aXVtLm9yZz4gd3JvdGU6Cj4gQ3VycmVudGx5IHRoZSBpbnRlbF9kcF9hdXhfYmFja2xpZ2h0IGRy aXZlciByZXF1aXJlcyBlRFAgcGFuZWwKPiB0byBub3QgYWxzbyBzdXBwb3J0IGJhY2tsaWdodCBh ZGp1c3RtZW50IHZpYSBQV00gcGluIHRvIHVzZQo+IHRoaXMgZHJpdmVyLgo+Cj4gVGhpcyBmb3Jj ZSB0aGUgZURQIHBhbmVsIHRoYXQgc3VwcG9ydCBib3RoIHdheXMgb2YgYmFja2xpZ2h0Cj4gYWRq dXN0bWVudCB0byBkbyBpdCB2aWEgUFdNIHBpbi4KCkN1cnJlbnRseSB0aGlzIGlzIGJ5IGRlc2ln bi4gQnV0IEkgdGhpbmsgd2UgYWdyZWVkIHByZXZpb3VzbHkgdGhhdCB0aGUKZHJpdmVyIGFsc28g aGFzIGluY29ycmVjdCBjYXBhYmlsaXR5IGNoZWNrcyBmb3IgdGhlIGN1cnJlbnQgZGVzaWduLiBU aGUKZmlyc3QgcHJpb3JpdHkgd291bGQgYmUgdG8gZml4IHRob3NlIGNoZWNrcy4gQW5kIHRoZSBw YXRjaCBvcmRlciBpbiB0aGUKc2VyaWVzIHNob3VsZCByZWZsZWN0IHRoYXQuCgo+IFRoaXMgcGF0 Y2ggYWRkcyB0aGUgbmV3IHByZWZlciBEUENEIG1vZGUgaW4gdGhlIGk5MTVfcGFyYW0KPiB0byBt YWtlIGl0IGVuYWJsZSB0byBwcmVmZXIgRFBDRCBvdmVyIHRoZSBQV00gdmlhIGtlcm5lbCBwYXJh bS4KPgo+IFRoaXMgcGF0Y2ggYWxzbyBhZGQgYSBjaGVjayB0byBEUF9FRFBfQkFDS0xJR0hUX0FV WF9FTkFCTEVfQ0FQCj4gaW4gc2V0X2F1eF9iYWNrbGlnaHRfZW5hYmxlKCkgc2luY2UgdGhlIGJh Y2tsaWdodCBlbmFibGVtZW50Cj4gY2FuIGJlIGRvbmUgdmlhIEJMX0VOQUJMRSBlRFAgY29ubmVj dG9yIHBpbiBpbiB0aGUgY2FzZSB0aGF0Cj4gaXQgZG9lcyBub3Qgc3VwcG9ydCBkb2luZyB0aGF0 IHZpYSBBVVguCgoiYWxzbyIgaW4gdGhlIGNvbW1pdCBtZXNzYWdlIGlzIGEgc3Ryb25nIGNsdWUg aXQgc2hvdWxkIGJlIGEgc2VwYXJhdGUKcGF0Y2guIFdoYXQgeW91IGRlc2NyaWJlIGlzIHBvdGVu dGlhbGx5IGEgZml4IHRoYXQgc2hvdWxkIHByZWNlZGUgdGhpcwpwYXRjaC4KCj4KPiBTaWduZWQt b2ZmLWJ5OiBQdXRoaWtvcm4gVm9yYXZvb3RpdmF0IDxwdXRoaWtAY2hyb21pdW0ub3JnPgo+IC0t LQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BhcmFtcy5jICAgICAgICAgICAgfCAgNiAr Ky0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BhcmFtcy5oICAgICAgICAgICAgfCAg MiArLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMgfCAz MyArKysrKysrKysrKysrKysrKysrLS0tLS0tLS0KPiAgMyBmaWxlcyBjaGFuZ2VkLCAyNyBpbnNl cnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X3BhcmFtcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wYXJhbXMu Ywo+IGluZGV4IGI2YTdlMzYzZDA3Ni4uOTYwMzkzZGQ1ZWRmIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfcGFyYW1zLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X3BhcmFtcy5jCj4gQEAgLTYzLDcgKzYzLDcgQEAgc3RydWN0IGk5MTVfcGFyYW1zIGk5 MTUgX19yZWFkX21vc3RseSA9IHsKPiAgCS5odWNfZmlybXdhcmVfcGF0aCA9IE5VTEwsCj4gIAku ZW5hYmxlX2RwX21zdCA9IHRydWUsCj4gIAkuaW5qZWN0X2xvYWRfZmFpbHVyZSA9IDAsCj4gLQku ZW5hYmxlX2RwY2RfYmFja2xpZ2h0ID0gZmFsc2UsCj4gKwkuZW5hYmxlX2RwY2RfYmFja2xpZ2h0 ID0gMCwKPiAgCS5lbmFibGVfZ3Z0ID0gZmFsc2UsCj4gIH07Cj4gIAo+IEBAIC0yNDYsOSArMjQ2 LDkgQEAgTU9EVUxFX1BBUk1fREVTQyhlbmFibGVfZHBfbXN0LAo+ICBtb2R1bGVfcGFyYW1fbmFt ZWRfdW5zYWZlKGluamVjdF9sb2FkX2ZhaWx1cmUsIGk5MTUuaW5qZWN0X2xvYWRfZmFpbHVyZSwg dWludCwgMDQwMCk7Cj4gIE1PRFVMRV9QQVJNX0RFU0MoaW5qZWN0X2xvYWRfZmFpbHVyZSwKPiAg CSJGb3JjZSBhbiBlcnJvciBhZnRlciBhIG51bWJlciBvZiBmYWlsdXJlIGNoZWNrIHBvaW50cyAo MDpkaXNhYmxlZCAoZGVmYXVsdCksIE46Zm9yY2UgZmFpbHVyZSBhdCB0aGUgTnRoIGZhaWx1cmUg Y2hlY2sgcG9pbnQpIik7Cj4gLW1vZHVsZV9wYXJhbV9uYW1lZChlbmFibGVfZHBjZF9iYWNrbGln aHQsIGk5MTUuZW5hYmxlX2RwY2RfYmFja2xpZ2h0LCBib29sLCAwNjAwKTsKPiArbW9kdWxlX3Bh cmFtX25hbWVkKGVuYWJsZV9kcGNkX2JhY2tsaWdodCwgaTkxNS5lbmFibGVfZHBjZF9iYWNrbGln aHQsIGludCwgMDYwMCk7Cj4gIE1PRFVMRV9QQVJNX0RFU0MoZW5hYmxlX2RwY2RfYmFja2xpZ2h0 LAo+IC0JIkVuYWJsZSBzdXBwb3J0IGZvciBEUENEIGJhY2tsaWdodCBjb250cm9sIChkZWZhdWx0 OmZhbHNlKSIpOwo+ICsJIkVuYWJsZSBzdXBwb3J0IGZvciBEUENEIGJhY2tsaWdodCBjb250cm9s ICgwOmRpc2FibGUgKGRlZmF1bHQpLCAxOnByZWZlciBQV00gcGluLCAyOiBwcmVmZXIgRFBDRCki KTsKClNlZSBteSBjb21tZW50cyBiZWxvdy4gSSB0aGluayB5b3UgbmVlZCB0byByZXRoaW5rIHRo ZSBvcHRpb25zLgoKPiAgCj4gIG1vZHVsZV9wYXJhbV9uYW1lZChlbmFibGVfZ3Z0LCBpOTE1LmVu YWJsZV9ndnQsIGJvb2wsIDA0MDApOwo+ICBNT0RVTEVfUEFSTV9ERVNDKGVuYWJsZV9ndnQsCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGFyYW1zLmggYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X3BhcmFtcy5oCj4gaW5kZXggMzQxNDhjYzg2MzdjLi5iZjZlMmM2 MGY2OTcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wYXJhbXMuaAo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGFyYW1zLmgKPiBAQCAtNTEsNiArNTEs NyBAQAo+ICAJZnVuYyhpbnQsIHVzZV9tbWlvX2ZsaXApOyBcCj4gIAlmdW5jKGludCwgbW1pb19k ZWJ1Zyk7IFwKPiAgCWZ1bmMoaW50LCBlZHBfdnN3aW5nKTsgXAo+ICsJZnVuYyhpbnQsIGVuYWJs ZV9kcGNkX2JhY2tsaWdodCk7IFwKPiAgCWZ1bmModW5zaWduZWQgaW50LCBpbmplY3RfbG9hZF9m YWlsdXJlKTsgXAo+ICAJLyogbGVhdmUgYm9vbHMgYXQgdGhlIGVuZCB0byBub3QgY3JlYXRlIGhv bGVzICovIFwKPiAgCWZ1bmMoYm9vbCwgYWxwaGFfc3VwcG9ydCk7IFwKPiBAQCAtNjYsNyArNjcs NiBAQAo+ICAJZnVuYyhib29sLCB2ZXJib3NlX3N0YXRlX2NoZWNrcyk7IFwKPiAgCWZ1bmMoYm9v bCwgbnVjbGVhcl9wYWdlZmxpcCk7IFwKPiAgCWZ1bmMoYm9vbCwgZW5hYmxlX2RwX21zdCk7IFwK PiAtCWZ1bmMoYm9vbCwgZW5hYmxlX2RwY2RfYmFja2xpZ2h0KTsgXAo+ICAJZnVuYyhib29sLCBl bmFibGVfZ3Z0KQo+ICAKPiAgI2RlZmluZSBNRU1CRVIoVCwgbWVtYmVyKSBUIG1lbWJlcgo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMKPiBpbmRleCA2 NTMyZTIyNmRiMjkuLjQyZjczZDlhM2NjZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMKPiBAQCAtMjgsNiArMjgsMTAgQEAgc3RhdGljIHZv aWQgc2V0X2F1eF9iYWNrbGlnaHRfZW5hYmxlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIGJv b2wgZW5hYmxlKQo+ICB7Cj4gIAl1aW50OF90IHJlZ192YWwgPSAwOwo+ICAKPiArCS8qIEVhcmx5 IHJldHVybiB3aGVuIGRpc3BsYXkgdXNlIG90aGVyIG1lY2hhbmlzbSB0byBlbmFibGUgYmFja2xp Z2h0LiAqLwo+ICsJaWYgKCEoaW50ZWxfZHAtPmVkcF9kcGNkWzFdICYgRFBfRURQX0JBQ0tMSUdI VF9BVVhfRU5BQkxFX0NBUCkpCj4gKwkJcmV0dXJuOwo+ICsKPiAgCWlmIChkcm1fZHBfZHBjZF9y ZWFkYigmaW50ZWxfZHAtPmF1eCwgRFBfRURQX0RJU1BMQVlfQ09OVFJPTF9SRUdJU1RFUiwKPiAg CQkJICAgICAgJnJlZ192YWwpIDwgMCkgewo+ICAJCURSTV9ERUJVR19LTVMoIkZhaWxlZCB0byBy ZWFkIERQQ0QgcmVnaXN0ZXIgMHgleFxuIiwKPiBAQCAtMTM4LDI3ICsxNDIsMzYgQEAgc3RhdGlj IGJvb2wKPiAgaW50ZWxfZHBfYXV4X2Rpc3BsYXlfY29udHJvbF9jYXBhYmxlKHN0cnVjdCBpbnRl bF9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiAgewo+ICAJc3RydWN0IGludGVsX2RwICppbnRlbF9k cCA9IGVuY190b19pbnRlbF9kcCgmY29ubmVjdG9yLT5lbmNvZGVyLT5iYXNlKTsKPiArCWJvb2wg c3VwcG9ydGVkOwo+ICAKPiAgCS8qIENoZWNrIHRoZSAgZURQIERpc3BsYXkgY29udHJvbCBjYXBh YmlsaXRpZXMgcmVnaXN0ZXJzIHRvIGRldGVybWluZSBpZgo+ICAJICogdGhlIHBhbmVsIGNhbiBz dXBwb3J0IGJhY2tsaWdodCBjb250cm9sIG92ZXIgdGhlIGF1eCBjaGFubmVsCj4gIAkgKi8KPiAt CWlmIChpbnRlbF9kcC0+ZWRwX2RwY2RbMV0gJiBEUF9FRFBfVENPTl9CQUNLTElHSFRfQURKVVNU TUVOVF9DQVAgJiYKPiAtCSAgICAoaW50ZWxfZHAtPmVkcF9kcGNkWzFdICYgRFBfRURQX0JBQ0tM SUdIVF9BVVhfRU5BQkxFX0NBUCkgJiYKPiAtCSAgICAhKChpbnRlbF9kcC0+ZWRwX2RwY2RbMV0g JiBEUF9FRFBfQkFDS0xJR0hUX1BJTl9FTkFCTEVfQ0FQKSB8fAo+IC0JICAgICAgKGludGVsX2Rw LT5lZHBfZHBjZFsyXSAmIERQX0VEUF9CQUNLTElHSFRfQlJJR0hUTkVTU19QV01fUElOX0NBUCkp KSB7Cj4gLQkJRFJNX0RFQlVHX0tNUygiQVVYIEJhY2tsaWdodCBDb250cm9sIFN1cHBvcnRlZCFc biIpOwo+IC0JCXJldHVybiB0cnVlOwo+ICsJc3dpdGNoIChpOTE1LmVuYWJsZV9kcGNkX2JhY2ts aWdodCkgewo+ICsJY2FzZSAxOiAvKiBwcmVmZXIgUFdNIHBpbiAqLwo+ICsJCXN1cHBvcnRlZCA9 IChpbnRlbF9kcC0+ZWRwX2RwY2RbMV0gJiBEUF9FRFBfVENPTl9CQUNLTElHSFRfQURKVVNUTUVO VF9DQVApICYmCj4gKwkJCSAgICAoaW50ZWxfZHAtPmVkcF9kcGNkWzFdICYgRFBfRURQX0JBQ0tM SUdIVF9BVVhfRU5BQkxFX0NBUCkgJiYKPiArCQkJICAgICEoaW50ZWxfZHAtPmVkcF9kcGNkWzFd ICYgRFBfRURQX0JBQ0tMSUdIVF9QSU5fRU5BQkxFX0NBUCkgJiYKPiArCQkJICAgICEoaW50ZWxf ZHAtPmVkcF9kcGNkWzJdICYgRFBfRURQX0JBQ0tMSUdIVF9CUklHSFRORVNTX1BXTV9QSU5fQ0FQ KTsKPiArCQlicmVhazsKClRoaXMgaXMgbm90IHJpZ2h0LiBJZiB3ZSdyZSBnb2luZyB0byB1c2Ug dGhlIFBXTSBwaW4gZm9yIGJhY2tsaWdodApjb250cm9sLCBpdCdzIHdoYXQncyBpbiBpbnRlbF9w YW5lbC5jLCBhbmQKaW50ZWxfZHBfYXV4X2luaXRfYmFja2xpZ2h0X2Z1bmNzKCkgc2hvdWxkIHJl dHVybiAtRU5PREVWLiBXZSBvbmx5CnN1cHBvcnQgb25lIG9yIHRoZSBvdGhlci4KCkkgdGhpbmsg eW91IHByb2JhYmx5IG5lZWQgdG8gaGF2ZSBhIGhhcmQgbG9vayBhdCBUYWJsZSAxMC0xICJTdW1t YXJ5IG9mCkJhY2tsaWdodCBDb250cm9sIE1vZGVzIFVzaW5nIERQQ0QgUmVnaXN0ZXJzIiBpbiBl RFAgMS40YiwgYW5kIHRlbGwgdXMKd2hhdCBtb2RlcyB5b3UgcmVhbGx5IHdhbnQgdG8gc3VwcG9y dCBhbmQgaG93LiBGb3IgZXhhbXBsZSwgdGhlIHByb2R1Y3QKbW9kZSBvciBhbnkgRFBDRC9QV00g bWl4ZWQgbW9kZXMgYXJlbid0IHZlcnkgZWFzaWx5IGFjaGlldmVkIHdpdGggdGhlCmN1cnJlbnQg ZGVzaWduLgoKQlIsCkphbmkuCgoKPiArCWNhc2UgMjogLyogcHJlZmVyIERQQ0QgKi8KPiArCQlz dXBwb3J0ZWQgPSAoaW50ZWxfZHAtPmVkcF9kcGNkWzFdICYgRFBfRURQX1RDT05fQkFDS0xJR0hU X0FESlVTVE1FTlRfQ0FQKSAmJgo+ICsJCQkgICAgKGludGVsX2RwLT5lZHBfZHBjZFsyXSAmIERQ X0VEUF9CQUNLTElHSFRfQlJJR0hUTkVTU19BVVhfU0VUX0NBUCk7Cj4gKwkJYnJlYWs7Cj4gKwlk ZWZhdWx0Ogo+ICsJCXN1cHBvcnRlZCA9IGZhbHNlOwo+ICAJfQo+IC0JcmV0dXJuIGZhbHNlOwo+ ICsKPiArCWlmIChzdXBwb3J0ZWQpCj4gKwkJRFJNX0RFQlVHX0tNUygiQVVYIEJhY2tsaWdodCBD b250cm9sIFN1cHBvcnRlZCFcbiIpOwo+ICsKPiArCXJldHVybiBzdXBwb3J0ZWQ7Cj4gIH0KPiAg Cj4gIGludCBpbnRlbF9kcF9hdXhfaW5pdF9iYWNrbGlnaHRfZnVuY3Moc3RydWN0IGludGVsX2Nv bm5lY3RvciAqaW50ZWxfY29ubmVjdG9yKQo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfcGFuZWwgKnBh bmVsID0gJmludGVsX2Nvbm5lY3Rvci0+cGFuZWw7Cj4gIAo+IC0JaWYgKCFpOTE1LmVuYWJsZV9k cGNkX2JhY2tsaWdodCkKPiAtCQlyZXR1cm4gLUVOT0RFVjsKPiAtCj4gIAlpZiAoIWludGVsX2Rw X2F1eF9kaXNwbGF5X2NvbnRyb2xfY2FwYWJsZShpbnRlbF9jb25uZWN0b3IpKQo+ICAJCXJldHVy biAtRU5PREVWOwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5 IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK