From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCREf-0003ET-6Q for qemu-devel@nongnu.org; Thu, 01 Dec 2016 08:17:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCREZ-00084C-GN for qemu-devel@nongnu.org; Thu, 01 Dec 2016 08:17:13 -0500 Received: from mail-yb0-x244.google.com ([2607:f8b0:4002:c09::244]:35609) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cCREZ-00083i-Bz for qemu-devel@nongnu.org; Thu, 01 Dec 2016 08:17:07 -0500 Received: by mail-yb0-x244.google.com with SMTP id d59so3450573ybi.2 for ; Thu, 01 Dec 2016 05:17:07 -0800 (PST) References: <20161201051433.17168-1-bobby.prani@gmail.com> From: Pranith Kumar In-reply-to: Date: Thu, 01 Dec 2016 08:17:05 -0500 Message-ID: <877f7j94by.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v5 00/19] Cleanup of TCG tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Alex =?utf-8?Q?Benn=C3=A9e?= , QEMU Developers , Richard Henderson Peter Maydell writes: > On 1 December 2016 at 05:14, Pranith Kumar wrote: >> Hello, >> >> This patch series cleans up the tcg tests in tests/tcg folder. > >> linux-user/mmap.c | 27 +++--- >> linux-user/syscall.c | 2 +- > > These aren't test code -- it would probably be better not > to mix actual bug fixes up in a series that's mostly trying > to fix up test code. OK, I will send these in a separate series. > > I'd still like to see what the plan is for having this > actually work given that you don't know whether there's a > cross-toolchain available. That's the fundamental reason > why these tests have been left to bitrot. The current idea is to call these tests explicitly with the cross compiler passed as an argument. We can, at the very least, download the cross compilers and enable the tests in travis. Thanks, -- Pranith