From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54806)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1c6YUe-0003dc-Pe
	for qemu-devel@nongnu.org; Tue, 15 Nov 2016 02:49:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1c6YUa-00049C-T8
	for qemu-devel@nongnu.org; Tue, 15 Nov 2016 02:49:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37302)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1c6YUa-00048t-Nd
	for qemu-devel@nongnu.org; Tue, 15 Nov 2016 02:49:20 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <1478566785-4002-1-git-send-email-ashish.mittal@veritas.com>
	<1478566785-4002-2-git-send-email-ashish.mittal@veritas.com>
	<20161114150701.GD26198@stefanha-x1.localdomain>
	<20161114154906.GC2373@lemon>
Date: Tue, 15 Nov 2016 08:49:17 +0100
In-Reply-To: <20161114154906.GC2373@lemon> (Fam Zheng's message of "Mon, 14
	Nov 2016 23:49:06 +0800")
Message-ID: <877f85qj2a.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new
 block device type called "vxhs"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Ashish Mittal <ashmit602@gmail.com>, Stefan Hajnoczi <stefanha@gmail.com>, kwolf@redhat.com, Venkatesha.Mg@veritas.com, ashish.mittal@veritas.com, jcody@redhat.com, qemu-devel@nongnu.org, Rakesh.Ranjan@veritas.com, Ketan.Nilangekar@veritas.com, Abhijit.Dey@veritas.com, pbonzini@redhat.com, Buddhi.Madhav@veritas.com

Fam Zheng <famz@redhat.com> writes:

> On Mon, 11/14 15:07, Stefan Hajnoczi wrote:
>> On Mon, Nov 07, 2016 at 04:59:44PM -0800, Ashish Mittal wrote:
>> > diff --git a/block/vxhs.c b/block/vxhs.c
>> > new file mode 100644
>> > index 0000000..8913e8f
>> > --- /dev/null
>> > +++ b/block/vxhs.c
>> > @@ -0,0 +1,689 @@
>> > +/*
>> > + * QEMU Block driver for Veritas HyperScale (VxHS)
>> > + *
>> > + * This work is licensed under the terms of the GNU GPL, version 2 or later.
>> > + * See the COPYING file in the top-level directory.
>> > + *
>> > + */
>> > +
>> > +#include "qemu/osdep.h"
>> > +#include "block/block_int.h"
>> > +#include <qnio/qnio_api.h>
>> 
>> Please move system headers (<>) above user headers ("").  This way you
>> can be sure the system header isn't affected by any macros defined by
>> user headers.
>
> Yes, but still after "qemu/osdep.h", which prepares necessary bits for any other
> headers.

Yes, osdep.h must come first.  See also scripts/clean-includes.