From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id 71sm14237392wmo.7.2016.11.10.10.08.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Nov 2016 10:08:41 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTPS id 6E5783E0060; Thu, 10 Nov 2016 18:08:41 +0000 (GMT) References: <20161109145748.27282-1-alex.bennee@linaro.org> <20161109145748.27282-16-alex.bennee@linaro.org> <23bbb76b-3009-373e-273e-b22e5a37a19b@twiddle.net> User-agent: mu4e 0.9.17; emacs 25.1.50.16 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Richard Henderson Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, mttcg@greensocs.com, fred.konrad@greensocs.com, a.rigo@virtualopensystems.com, cota@braap.org, bobby.prani@gmail.com, nikunj@linux.vnet.ibm.com, mark.burton@greensocs.com, jan.kiszka@siemens.com, serge.fdrv@gmail.com, peter.maydell@linaro.org, claudio.fontana@huawei.com, "open list\:ARM" Subject: Re: [PATCH v6 15/19] target-arm/cpu: don't reset TLB structures, use cputlb to do it In-reply-to: <23bbb76b-3009-373e-273e-b22e5a37a19b@twiddle.net> Date: Thu, 10 Nov 2016 18:08:41 +0000 Message-ID: <877f8b8axi.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-TUID: awIDdJy2bwoa Richard Henderson writes: > On 11/09/2016 03:57 PM, Alex Bennée wrote: >> +#ifdef CONFIG_SOFTMMU >> + memset(env, 0, offsetof(CPUARMState, tlb_table)); >> + tlb_flush(s, 0); >> +#else >> memset(env, 0, offsetof(CPUARMState, features)); >> +#endif > > I'd really prefer to see the tlb_flush be moved into parent_reset, so that we > handle it identically for all targets. Yeah I'll prepare a series to do that separate from MTTCG. > > As for the memset, do we really need to distinguish softmmu? I don't like you > picking out a variable name within CPU_COMMON. Better to use empty struct > markers, like the > > struct {} start_init_save; > > that x86 uses. OK fair enough. -- Alex Bennée From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4tmJ-0002xc-Am for qemu-devel@nongnu.org; Thu, 10 Nov 2016 13:08:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4tmG-0003zd-5U for qemu-devel@nongnu.org; Thu, 10 Nov 2016 13:08:47 -0500 Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:37528) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c4tmF-0003zE-Uc for qemu-devel@nongnu.org; Thu, 10 Nov 2016 13:08:44 -0500 Received: by mail-wm0-x236.google.com with SMTP id t79so48146475wmt.0 for ; Thu, 10 Nov 2016 10:08:43 -0800 (PST) References: <20161109145748.27282-1-alex.bennee@linaro.org> <20161109145748.27282-16-alex.bennee@linaro.org> <23bbb76b-3009-373e-273e-b22e5a37a19b@twiddle.net> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <23bbb76b-3009-373e-273e-b22e5a37a19b@twiddle.net> Date: Thu, 10 Nov 2016 18:08:41 +0000 Message-ID: <877f8b8axi.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v6 15/19] target-arm/cpu: don't reset TLB structures, use cputlb to do it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, mttcg@greensocs.com, fred.konrad@greensocs.com, a.rigo@virtualopensystems.com, cota@braap.org, bobby.prani@gmail.com, nikunj@linux.vnet.ibm.com, mark.burton@greensocs.com, jan.kiszka@siemens.com, serge.fdrv@gmail.com, peter.maydell@linaro.org, claudio.fontana@huawei.com, "open list:ARM" Richard Henderson writes: > On 11/09/2016 03:57 PM, Alex Bennée wrote: >> +#ifdef CONFIG_SOFTMMU >> + memset(env, 0, offsetof(CPUARMState, tlb_table)); >> + tlb_flush(s, 0); >> +#else >> memset(env, 0, offsetof(CPUARMState, features)); >> +#endif > > I'd really prefer to see the tlb_flush be moved into parent_reset, so that we > handle it identically for all targets. Yeah I'll prepare a series to do that separate from MTTCG. > > As for the memset, do we really need to distinguish softmmu? I don't like you > picking out a variable name within CPU_COMMON. Better to use empty struct > markers, like the > > struct {} start_init_save; > > that x86 uses. OK fair enough. -- Alex Bennée