From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915/gtt: Mark tlbs dirty on clear
Date: Mon, 31 Oct 2016 17:58:15 +0200 [thread overview]
Message-ID: <877f8opl2g.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20161031154940.GD30109@nuc-i3427.alporthouse.com>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> On Mon, Oct 31, 2016 at 05:24:46PM +0200, Mika Kuoppala wrote:
>> Now when clearing ptes can modify upper level pdp's,
>> we need to mark them dirty so that they will be flushed
>> correctly.
>
> I suppose so.
It is a bit iffy if we really do, but this way we gain symmetry
with the alloc side.
I pondered why this is missing from 4l side, but in there the
topmost pointer is static.
-Mika
> I think we could push this into the cleanup_px() (and
> alloc) but that is probably a fair chunk of work for immeasurable gain.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-31 15:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 15:24 [PATCH 1/2] drm/i915/gtt: Fix pte clear range Mika Kuoppala
2016-10-31 15:24 ` [PATCH 2/2] drm/i915/gtt: Mark tlbs dirty on clear Mika Kuoppala
2016-10-31 15:49 ` Chris Wilson
2016-10-31 15:58 ` Mika Kuoppala [this message]
2016-10-31 17:14 ` Chris Wilson
2016-10-31 15:42 ` [PATCH 1/2] drm/i915/gtt: Fix pte clear range Chris Wilson
2016-10-31 15:46 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] " Patchwork
2016-10-31 15:55 ` [PATCH 1/2] " Mika Kuoppala
2016-11-01 8:19 ` Joonas Lahtinen
2016-11-01 10:22 ` Mika Kuoppala
2016-11-01 10:28 ` Chris Wilson
2016-10-31 16:16 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915/gtt: Fix pte clear range (rev2) Patchwork
2016-11-01 13:27 ` [PATCH 1/2] drm/i915/gtt: Fix pte clear range Mika Kuoppala
2016-11-02 9:29 ` Joonas Lahtinen
2016-11-01 15:46 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915/gtt: Fix pte clear range (rev3) Patchwork
2016-11-01 16:28 ` Mika Kuoppala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877f8opl2g.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.