From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752727AbcGAJtL (ORCPT ); Fri, 1 Jul 2016 05:49:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45294 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752164AbcGAJtG (ORCPT ); Fri, 1 Jul 2016 05:49:06 -0400 From: Vitaly Kuznetsov To: David Vrabel Cc: , , , Stefano Stabellini , "Boris Ostrovsky" , Juergen Gross , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Julien Grall Subject: Re: [PATCH linux 0/8] xen: pvhvm: support bootup on secondary vCPUs References: <1467132449-1030-1-git-send-email-vkuznets@redhat.com> <5772B4C2.4010906@citrix.com> <871t3gwe0o.fsf@vitty.brq.redhat.com> <5773C0DF.3090905@citrix.com> Date: Fri, 01 Jul 2016 11:24:21 +0200 In-Reply-To: <5773C0DF.3090905@citrix.com> (David Vrabel's message of "Wed, 29 Jun 2016 13:36:47 +0100") Message-ID: <877fd5u2wq.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 01 Jul 2016 09:24:25 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Vrabel writes: > On 29/06/16 10:16, Vitaly Kuznetsov wrote: >> David Vrabel writes: >> >>> On 28/06/16 17:47, Vitaly Kuznetsov wrote: >>>> It may happen that Xen's and Linux's ideas of vCPU id diverge. In >>>> particular, when we crash on a secondary vCPU we may want to do kdump >>>> and unlike plain kexec where we do migrate_to_reboot_cpu() we try booting >>>> on the vCPU which crashed. This doesn't work very well for PVHVM guests as >>>> we have a number of hypercalls where we pass vCPU id as a parameter. These >>>> hypercalls either fail or do something unexpected. To solve the issue we >>>> need to have a mapping between Linux's and Xen's vCPU ids. >>> >>> Could the soft-reboot hypercall (optionally) return on vcpu 0? >>> >> >> In theory, yes, I think we can re-arrange vCPUs inside the hypervisor so >> Linux will get them in the natural order after soft reset. > > The series is straight forwards and the concept of the guest having to > map its idea of CPU to VCPU is fine, so unless you think a hypervisor > based solution is better we can take this series once it's fixed up. I'm afraid that kdump is not the only case where the mapping may come handy. Linux CPU ids are not guaranteed to always match the order of CPUs in MADT, e.g. if we fail to add a CPU ids for the rest will get shifted. This could easily be emulated by adding 'disable_cpu_apicid=' kernel parameter. I didn't try but I'm pretty sure that disabling any CPU will break guest bootup. That said, I think maintaining the Xen-Linux vCPU id mapping is preferred till we introduce an option to address vCPUs in hypercalls by some other ids (vLAPIC id, for example). -- Vitaly From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vitaly Kuznetsov Subject: Re: [PATCH linux 0/8] xen: pvhvm: support bootup on secondary vCPUs Date: Fri, 01 Jul 2016 11:24:21 +0200 Message-ID: <877fd5u2wq.fsf@vitty.brq.redhat.com> References: <1467132449-1030-1-git-send-email-vkuznets@redhat.com> <5772B4C2.4010906@citrix.com> <871t3gwe0o.fsf@vitty.brq.redhat.com> <5773C0DF.3090905@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bIugX-00077O-67 for xen-devel@lists.xenproject.org; Fri, 01 Jul 2016 09:24:29 +0000 In-Reply-To: <5773C0DF.3090905@citrix.com> (David Vrabel's message of "Wed, 29 Jun 2016 13:36:47 +0100") List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: David Vrabel Cc: Juergen Gross , Stefano Stabellini , x86@kernel.org, linux-kernel@vger.kernel.org, Julien Grall , Ingo Molnar , "H. Peter Anvin" , xen-devel@lists.xenproject.org, Boris Ostrovsky , Thomas Gleixner List-Id: xen-devel@lists.xenproject.org RGF2aWQgVnJhYmVsIDxkYXZpZC52cmFiZWxAY2l0cml4LmNvbT4gd3JpdGVzOgoKPiBPbiAyOS8w Ni8xNiAxMDoxNiwgVml0YWx5IEt1em5ldHNvdiB3cm90ZToKPj4gRGF2aWQgVnJhYmVsIDxkYXZp ZC52cmFiZWxAY2l0cml4LmNvbT4gd3JpdGVzOgo+PiAKPj4+IE9uIDI4LzA2LzE2IDE3OjQ3LCBW aXRhbHkgS3V6bmV0c292IHdyb3RlOgo+Pj4+IEl0IG1heSBoYXBwZW4gdGhhdCBYZW4ncyBhbmQg TGludXgncyBpZGVhcyBvZiB2Q1BVIGlkIGRpdmVyZ2UuIEluCj4+Pj4gcGFydGljdWxhciwgd2hl biB3ZSBjcmFzaCBvbiBhIHNlY29uZGFyeSB2Q1BVIHdlIG1heSB3YW50IHRvIGRvIGtkdW1wCj4+ Pj4gYW5kIHVubGlrZSBwbGFpbiBrZXhlYyB3aGVyZSB3ZSBkbyBtaWdyYXRlX3RvX3JlYm9vdF9j cHUoKSB3ZSB0cnkgYm9vdGluZwo+Pj4+IG9uIHRoZSB2Q1BVIHdoaWNoIGNyYXNoZWQuIFRoaXMg ZG9lc24ndCB3b3JrIHZlcnkgd2VsbCBmb3IgUFZIVk0gZ3Vlc3RzIGFzCj4+Pj4gd2UgaGF2ZSBh IG51bWJlciBvZiBoeXBlcmNhbGxzIHdoZXJlIHdlIHBhc3MgdkNQVSBpZCBhcyBhIHBhcmFtZXRl ci4gVGhlc2UKPj4+PiBoeXBlcmNhbGxzIGVpdGhlciBmYWlsIG9yIGRvIHNvbWV0aGluZyB1bmV4 cGVjdGVkLiBUbyBzb2x2ZSB0aGUgaXNzdWUgd2UKPj4+PiBuZWVkIHRvIGhhdmUgYSBtYXBwaW5n IGJldHdlZW4gTGludXgncyBhbmQgWGVuJ3MgdkNQVSBpZHMuCj4+Pgo+Pj4gQ291bGQgdGhlIHNv ZnQtcmVib290IGh5cGVyY2FsbCAob3B0aW9uYWxseSkgcmV0dXJuIG9uIHZjcHUgMD8KPj4+Cj4+ IAo+PiBJbiB0aGVvcnksIHllcywgSSB0aGluayB3ZSBjYW4gcmUtYXJyYW5nZSB2Q1BVcyBpbnNp ZGUgdGhlIGh5cGVydmlzb3Igc28KPj4gTGludXggd2lsbCBnZXQgdGhlbSBpbiB0aGUgbmF0dXJh bCBvcmRlciBhZnRlciBzb2Z0IHJlc2V0Lgo+Cj4gVGhlIHNlcmllcyBpcyBzdHJhaWdodCBmb3J3 YXJkcyBhbmQgdGhlIGNvbmNlcHQgb2YgdGhlIGd1ZXN0IGhhdmluZyB0bwo+IG1hcCBpdHMgaWRl YSBvZiBDUFUgdG8gVkNQVSBpcyBmaW5lLCBzbyB1bmxlc3MgeW91IHRoaW5rIGEgaHlwZXJ2aXNv cgo+IGJhc2VkIHNvbHV0aW9uIGlzIGJldHRlciB3ZSBjYW4gdGFrZSB0aGlzIHNlcmllcyBvbmNl IGl0J3MgZml4ZWQgdXAuCgpJJ20gYWZyYWlkIHRoYXQga2R1bXAgaXMgbm90IHRoZSBvbmx5IGNh c2Ugd2hlcmUgdGhlIG1hcHBpbmcgbWF5IGNvbWUKaGFuZHkuIExpbnV4IENQVSBpZHMgYXJlIG5v dCBndWFyYW50ZWVkIHRvIGFsd2F5cyBtYXRjaCB0aGUgb3JkZXIgb2YKQ1BVcyBpbiBNQURULCBl LmcuIGlmIHdlIGZhaWwgdG8gYWRkIGEgQ1BVIGlkcyBmb3IgdGhlIHJlc3Qgd2lsbCBnZXQKc2hp ZnRlZC4gVGhpcyBjb3VsZCBlYXNpbHkgYmUgZW11bGF0ZWQgYnkgYWRkaW5nICdkaXNhYmxlX2Nw dV9hcGljaWQ9JwprZXJuZWwgcGFyYW1ldGVyLiBJIGRpZG4ndCB0cnkgYnV0IEknbSBwcmV0dHkg c3VyZSB0aGF0IGRpc2FibGluZyBhbnkKQ1BVIHdpbGwgYnJlYWsgZ3Vlc3QgYm9vdHVwLiBUaGF0 IHNhaWQsIEkgdGhpbmsgbWFpbnRhaW5pbmcgdGhlClhlbi1MaW51eCB2Q1BVIGlkIG1hcHBpbmcg aXMgcHJlZmVycmVkIHRpbGwgd2UgaW50cm9kdWNlIGFuIG9wdGlvbiB0bwphZGRyZXNzIHZDUFVz IGluIGh5cGVyY2FsbHMgYnkgc29tZSBvdGhlciBpZHMgKHZMQVBJQyBpZCwgZm9yIGV4YW1wbGUp LgoKLS0gCiAgVml0YWx5CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0 dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=