From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIcki-0007PL-TB for qemu-devel@nongnu.org; Thu, 30 Jun 2016 10:15:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bIckd-00048Z-P5 for qemu-devel@nongnu.org; Thu, 30 Jun 2016 10:15:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIckc-00048E-VM for qemu-devel@nongnu.org; Thu, 30 Jun 2016 10:15:31 -0400 From: Markus Armbruster References: <1467104499-27517-1-git-send-email-pl@kamp.de> <1467104499-27517-12-git-send-email-pl@kamp.de> <4bc07277-a456-11b2-f150-6daf470b408a@redhat.com> <5772563E.607@kamp.de> Date: Thu, 30 Jun 2016 16:15:28 +0200 In-Reply-To: <5772563E.607@kamp.de> (Peter Lieven's message of "Tue, 28 Jun 2016 12:49:34 +0200") Message-ID: <877fd669vj.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 11/15] qom: use mmap for bigger Objects List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: Paolo Bonzini , qemu-devel@nongnu.org, kwolf@redhat.com, peter.maydell@linaro.org, mst@redhat.com, dgilbert@redhat.com, mreitz@redhat.com, kraxel@redhat.com Peter Lieven writes: > Am 28.06.2016 um 12:42 schrieb Paolo Bonzini: >> >> On 28/06/2016 11:01, Peter Lieven wrote: >>> Signed-off-by: Peter Lieven >>> --- >>> include/qom/object.h | 1 + >>> qom/object.c | 20 +++++++++++++++++--- >>> 2 files changed, 18 insertions(+), 3 deletions(-) >> No, please---glibc should be fixed instead. > > The objects we allocate are sometimes as big as 70kB... That's a rather pedestrian size, isn't it? If malloc() sucks at managing such sizes, it needs fixing very badly.