From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.parknet.co.jp ([210.171.160.6]:56886 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750853AbcFXJD6 (ORCPT ); Fri, 24 Jun 2016 05:03:58 -0400 From: OGAWA Hirofumi To: Andrew Morton Cc: Zheng Lv , linux-fsdevel@vger.kernel.org, trivial@kernel.org Subject: Re: [PATCH] fat: fix error message for bogus number of directory entries References: <1466746260-11721-1-git-send-email-lv.zheng.2015@gmail.com> Date: Fri, 24 Jun 2016 18:03:53 +0900 In-Reply-To: <1466746260-11721-1-git-send-email-lv.zheng.2015@gmail.com> (Zheng Lv's message of "Fri, 24 Jun 2016 01:31:00 -0400") Message-ID: <877fdfm006.fsf@mail.parknet.co.jp> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Zheng Lv writes: > "bogus directory-entries per block" was reported for what was instead > bogus number of directory entries. The message also mismatched the > argument passed to printk(), which was sbi->dir_entries. > > Fix this by replacing the message with "bogus number of directory > entries". printk() argument was kept unchanged. > > Signed-off-by: Zheng Lv > Cc: trivial@kernel.org Acked-by: OGAWA Hirofumi > --- > Note that this patch would possibly confuse users who receive the error message from an old kernel but grep in the patched source tree. However, I think this case is rare enough to be ignored. > > > fs/fat/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/fat/inode.c b/fs/fat/inode.c > index 3bcf579..d26a5ce 100644 > --- a/fs/fat/inode.c > +++ b/fs/fat/inode.c > @@ -1726,7 +1726,7 @@ int fat_fill_super(struct super_block *sb, void *data, int silent, int isvfat, > sbi->dir_entries = bpb.fat_dir_entries; > if (sbi->dir_entries & (sbi->dir_per_block - 1)) { > if (!silent) > - fat_msg(sb, KERN_ERR, "bogus directory-entries per block" > + fat_msg(sb, KERN_ERR, "bogus number of directory entries" > " (%u)", sbi->dir_entries); > goto out_invalid; > } -- OGAWA Hirofumi