From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38276)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bEuAP-0004Kv-Qj
	for qemu-devel@nongnu.org; Mon, 20 Jun 2016 04:02:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bEuAK-0006ea-Qx
	for qemu-devel@nongnu.org; Mon, 20 Jun 2016 04:02:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43840)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bEuAK-0006eW-LP
	for qemu-devel@nongnu.org; Mon, 20 Jun 2016 04:02:40 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 3ADC877323
	for <qemu-devel@nongnu.org>; Mon, 20 Jun 2016 08:02:40 +0000 (UTC)
From: Markus Armbruster <armbru@redhat.com>
References: <1466022773-8965-1-git-send-email-ehabkost@redhat.com>
	<1466022773-8965-5-git-send-email-ehabkost@redhat.com>
Date: Mon, 20 Jun 2016 10:02:38 +0200
In-Reply-To: <1466022773-8965-5-git-send-email-ehabkost@redhat.com> (Eduardo
	Habkost's message of "Wed, 15 Jun 2016 17:32:47 -0300")
Message-ID: <877fdkcmox.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 04/10] qdev: Use error_prepend() for errors
 applying globals
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Marcel Apfelbaum <marcel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Igor Mammedov <imammedo@redhat.com>

Eduardo Habkost <ehabkost@redhat.com> writes:

> The same Error* will be used in an error_propagate() call in the
> future, so prepend a "can't apply global" prefix to it.

What future?  A future patch?

> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  hw/core/qdev-properties.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
> index 64e17aa..cd19603 100644
> --- a/hw/core/qdev-properties.c
> +++ b/hw/core/qdev-properties.c
> @@ -1079,8 +1079,9 @@ static void qdev_prop_set_globals_for_type(DeviceState *dev,
>          object_property_parse(OBJECT(dev), prop->value, prop->property, &err);
>          if (err != NULL) {
>              assert(prop->user_provided);
> -            error_reportf_err(err, "Warning: global %s.%s=%s ignored: ",
> -                              prop->driver, prop->property, prop->value);
> +            error_prepend(&err, "can't apply global %s.%s=%s: ",
> +                          prop->driver, prop->property, prop->value);
> +            error_reportf_err(err, "Warning: ");
>          }
>      }
>  }

You reword the error message.  Should be mentioned in the commit
message.

Why do you need to prepend the "Warning: ..." in two steps, first
error_prepend() for the "...", then error_reportf_err() for "Warning: "?
Perhaps it'll become clear later in the series, but it's not obvious
now.