From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8U7g-0004kp-Qs for qemu-devel@nongnu.org; Thu, 02 Jun 2016 11:01:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8U7b-0002N4-3o for qemu-devel@nongnu.org; Thu, 02 Jun 2016 11:01:24 -0400 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:48092) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8U7a-0002M5-P2 for qemu-devel@nongnu.org; Thu, 02 Jun 2016 11:01:19 -0400 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 2 Jun 2016 16:01:13 +0100 From: Sascha Silbe In-Reply-To: <1464717764-9040-5-git-send-email-duanj@linux.vnet.ibm.com> References: <1464717764-9040-1-git-send-email-duanj@linux.vnet.ibm.com> <1464717764-9040-5-git-send-email-duanj@linux.vnet.ibm.com> Date: Thu, 02 Jun 2016 17:01:04 +0200 Message-ID: <877fe7iqj3.fsf@oc4731375738.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [QEMU RFC PATCH v3 4/6] Migration: migrate QTAILQ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jianjun Duan , qemu-devel@nongnu.org Cc: veroniabahaa@gmail.com, peter.maydell@linaro.org, mst@redhat.com, quintela@redhat.com, mark.cave-ayland@ilande.co.uk, mdroth@linux.vnet.ibm.com, mreitz@redhat.com, blauwirbel@gmail.com, amit.shah@redhat.com, qemu-ppc@nongnu.org, kraxel@redhat.com, kwolf@redhat.com, dmitry@daynix.com, pbonzini@redhat.com, rth@twiddle.net, leon.alrae@imgtec.com, aurelien@aurel32.net, david@gibson.dropbear.id.au Dear Jianjun, Jianjun Duan writes: [include/migration/vmstate.h] > @@ -185,6 +185,8 @@ enum VMStateFlags { > * to determine the number of entries in the array. Only valid in > * combination with one of VMS_VARRAY*. */ > VMS_MULTIPLY_ELEMENTS =3D 0x4000, > + /* For fields which need customized handling, such as QTAILQ in queu= e.h*/ > + VMS_CSTM =3D 0x8000, Can you describe (in the comment) how this customised handling is performed, please? I.e. describe what exactly happens if the flag is set, from the point of view of an API consumer. Also, why do you need this flag at all? The only change I can see is that you pass additional information to VMStateInfo.get() / .put(), using NULL if it's not set. Why don't you just always pass the additional information? If the additional information is not needed by get() / put() the parameter will be unused anyway. Sascha --=20 Softwareentwicklung Sascha Silbe, Niederhofenstra=C3=9Fe 5/1, 71229 Leonberg https://se-silbe.de/ USt-IdNr. DE281696641