From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1b85lu-00086d-B0 for ath10k@lists.infradead.org; Wed, 01 Jun 2016 13:01:18 +0000 From: "Valo, Kalle" Subject: Re: [PATCH v2] ath10k: Fix 10.4 extended peer stats update Date: Wed, 1 Jun 2016 13:00:40 +0000 Message-ID: <877fe92he0.fsf@kamboji.qca.qualcomm.com> References: <1464339926-12136-1-git-send-email-mohammed@qca.qualcomm.com> <87vb1ucten.fsf@qca.qualcomm.com> <20160531133700.GB3146@atheros-ThinkPad-T61> <87r3cicaxi.fsf@qca.qualcomm.com> <20160601090805.GA7773@atheros-ThinkPad-T61> In-Reply-To: <20160601090805.GA7773@atheros-ThinkPad-T61> (Mohammed Shafi Shajakhan's message of "Wed, 1 Jun 2016 14:38:05 +0530") Content-Language: en-US Content-ID: MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Mohammed Shafi Shajakhan Cc: "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" , "Shajakhan, Mohammed Shafi (Mohammed Shafi)" Mohammed Shafi Shajakhan writes: > Hello, > > On Tue, May 31, 2016 at 06:57:52PM +0000, Valo, Kalle wrote: >> Mohammed Shafi Shajakhan writes: >> >> >> > +void ath10k_sta_update_rx_duration(struct ath10k *ar, >> >> > + struct ath10k_fw_stats *stats) >> >> > +{ >> >> > + struct ath10k_fw_file *fw_file = &ar->normal_mode_fw.fw_file; >> >> > + >> >> > + if (fw_file->wmi_op_version < ATH10K_FW_WMI_OP_VERSION_10_4) >> >> > + ath10k_sta_update_stats_rx_duration(ar, &stats->peers); >> >> > + else >> >> > + ath10k_sta_update_extd_stats_rx_duration(ar, >> >> > + &stats->peers_extd); >> >> > +} >> >> >> >> _Ideally_ wmi_op_version should be used only in ath10k_wmi_attach() and >> >> nowhere else. Isn't there any other way to detect this scenario? For >> >> example, what if you store stats_id to struct ath10k_fw_stats and do >> >> something like this: >> >> >> >> if (stats->stats_id & WMI_10_4_STAT_PEER_EXTD) >> >> ath10k_sta_update_extd_stats_rx_duration(ar, >> >> &stats->peers_extd); >> >> else >> >> ath10k_sta_update_stats_rx_duration(ar, &stats->peers); >> >> >> >> Would that work? >> > >> > [shafi] I am also thinking to re-use (ar->fw_stats_req_mask & WMI_10_4_STAT_PEER_EXTD) >> > it might work, but will it conflict vdev stats WMI_STAT_VDEV (though its not currently >> > supported for 10.2 ) >> >> Can you describe more how they conflict? > > [shafi] 'WMI_STAT_VDEV' and 'WMI_10_4_STAT_PEER_EXTD' are having the same value > BIT(3), though as of now we are only 'WMI_10_4_STAT_PEER_EXTD' for 10.4 Ah. But that's easy to solve, for example you could use a bool instead. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:34726 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbcFANA6 convert rfc822-to-8bit (ORCPT ); Wed, 1 Jun 2016 09:00:58 -0400 From: "Valo, Kalle" To: Mohammed Shafi Shajakhan CC: "Shajakhan, Mohammed Shafi (Mohammed Shafi)" , "ath10k@lists.infradead.org" , "linux-wireless@vger.kernel.org" Subject: Re: [PATCH v2] ath10k: Fix 10.4 extended peer stats update Date: Wed, 1 Jun 2016 13:00:40 +0000 Message-ID: <877fe92he0.fsf@kamboji.qca.qualcomm.com> (sfid-20160601_150102_888965_FFEE70BD) References: <1464339926-12136-1-git-send-email-mohammed@qca.qualcomm.com> <87vb1ucten.fsf@qca.qualcomm.com> <20160531133700.GB3146@atheros-ThinkPad-T61> <87r3cicaxi.fsf@qca.qualcomm.com> <20160601090805.GA7773@atheros-ThinkPad-T61> In-Reply-To: <20160601090805.GA7773@atheros-ThinkPad-T61> (Mohammed Shafi Shajakhan's message of "Wed, 1 Jun 2016 14:38:05 +0530") Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Mohammed Shafi Shajakhan writes: > Hello, > > On Tue, May 31, 2016 at 06:57:52PM +0000, Valo, Kalle wrote: >> Mohammed Shafi Shajakhan writes: >> >> >> > +void ath10k_sta_update_rx_duration(struct ath10k *ar, >> >> > + struct ath10k_fw_stats *stats) >> >> > +{ >> >> > + struct ath10k_fw_file *fw_file = &ar->normal_mode_fw.fw_file; >> >> > + >> >> > + if (fw_file->wmi_op_version < ATH10K_FW_WMI_OP_VERSION_10_4) >> >> > + ath10k_sta_update_stats_rx_duration(ar, &stats->peers); >> >> > + else >> >> > + ath10k_sta_update_extd_stats_rx_duration(ar, >> >> > + &stats->peers_extd); >> >> > +} >> >> >> >> _Ideally_ wmi_op_version should be used only in ath10k_wmi_attach() and >> >> nowhere else. Isn't there any other way to detect this scenario? For >> >> example, what if you store stats_id to struct ath10k_fw_stats and do >> >> something like this: >> >> >> >> if (stats->stats_id & WMI_10_4_STAT_PEER_EXTD) >> >> ath10k_sta_update_extd_stats_rx_duration(ar, >> >> &stats->peers_extd); >> >> else >> >> ath10k_sta_update_stats_rx_duration(ar, &stats->peers); >> >> >> >> Would that work? >> > >> > [shafi] I am also thinking to re-use (ar->fw_stats_req_mask & WMI_10_4_STAT_PEER_EXTD) >> > it might work, but will it conflict vdev stats WMI_STAT_VDEV (though its not currently >> > supported for 10.2 ) >> >> Can you describe more how they conflict? > > [shafi] 'WMI_STAT_VDEV' and 'WMI_10_4_STAT_PEER_EXTD' are having the same value > BIT(3), though as of now we are only 'WMI_10_4_STAT_PEER_EXTD' for 10.4 Ah. But that's easy to solve, for example you could use a bool instead. -- Kalle Valo