Re: Patch "paride: make 'verbose' parameter an 'int' again" has been added to the 3.14-stable tree

[Rusty Russell <rusty@rustcorp.com.au>]

Arnd Bergmann <arnd@arndb.de> writes:
> On Tuesday 03 May 2016 07:04:10 Rusty Russell wrote:
>> Because it *never* worked.  90ab5ee94171 changed it to a bool, but it
>> was already module_param(bool) so you could never set it to 2.  ... And
>> it's been module_param(bool) before 2005.
>> 
>> But this breaks anyone who has been using just "verbose" or "verbose=y".
>> 
>> Fortunately, I'm sure nobody cares about it?
>
> Right. I think we can safely make that assumption that nobody cares
> about the new change in behavior. As I tried to explain in the changelog,
> the bug of not being able to set verbose=2 is historic, and I am
> not worried about it. Your patch from 2012 makes the driver more
> consistent, but it does introduce what has now become a gcc warning.
>
> We probably don't care about that in backports, because nobody uses
> the driver and people rarely build older kernels with the latest
> gcc release, if that's even possible.
>
> FWIW, I've managed to find how the odd behavior was introduced originally
> in linux-2.6.11 just before the start of git, see below for giggles.
> I'm also sure that nobody cared about the verbose=2 syntax breaking back
> then, it was already obsolete technology even at the turn of the century.

Yeah, I suspected it was my screwup originally :)

Thanks!
Rusty.

> 	Arnd
>
> ---
> commit 3352539ac7e770a69b003f4a0952f817695b9204
> Author: Andrew Morton <akpm@osdl.org>
> Date:   Fri Jan 7 22:21:50 2005 -0800
>
>     [PATCH] MODULE_PARM conversions
>     
>     Rusty Russell <rusty@rustcorp.com.au>
>     
>     MODULE_PARM conversions for x86 `allyesconfig'.
>     
>     Signed-off-by: Andrew Morton <akpm@osdl.org>
>     Signed-off-by: Linus Torvalds <torvalds@osdl.org>
>
> diff --git a/drivers/block/paride/pd.c b/drivers/block/paride/pd.c
> index 5f6534d..c4c8f0d 100644
> --- a/drivers/block/paride/pd.c
> +++ b/drivers/block/paride/pd.c
> @@ -178,15 +178,15 @@ void pd_setup(char *str, int *ints)
>  
>  #endif
>  
> -MODULE_PARM(verbose, "i");
> -MODULE_PARM(major, "i");
> -MODULE_PARM(name, "s");
> -MODULE_PARM(cluster, "i");
> -MODULE_PARM(nice, "i");
> -MODULE_PARM(drive0, "1-8i");
> -MODULE_PARM(drive1, "1-8i");
> -MODULE_PARM(drive2, "1-8i");
> -MODULE_PARM(drive3, "1-8i");
> +module_param(verbose, bool, 0);
> +module_param(major, int, 0);
> +module_param(name, charp, 0);
> +module_param(cluster, int, 0);
> +module_param(nice, int, 0);
> +module_param_array(drive0, int, NULL, 0);
> +module_param_array(drive1, int, NULL, 0);
> +module_param_array(drive2, int, NULL, 0);
> +module_param_array(drive3, int, NULL, 0);
>  
>  #include "paride.h"
>