From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] yajl: fix static linking in a parallel build
Date: Fri, 15 Apr 2016 20:27:15 +0200 [thread overview]
Message-ID: <877ffyhgn0.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1460240125-2981-1-git-send-email-joerg.krause@embedded.rocks> ("Jörg Krause"'s message of "Sun, 10 Apr 2016 00:15:25 +0200")
>>>>> "J?rg" == J?rg Krause <joerg.krause@embedded.rocks> writes:
> The yajl build system contains a race condition, which gets triggered by
> high BR2_JLEVEL settings - It tries to link the executable gen-extra-close
> against the shared libyajl before it is created:
> [ 21%] Linking C executable gen-extra-close
> [ 26%] Building C object src/CMakeFiles/yajl_s.dir/yajl_buf.c.o
> /home/test/autobuild/instance-3/output/host/opt/ext-toolchain/bfin-uclinux/bfin-uclinux/bin/ld.real: cannot find -lyajl
> Fix this issue by linking gen-extra-close against the shared library in a shared
> build and the static library otherwise.
> Apply this to all other build targets from yail who are linking against the
> library, too.
> Fixes:
> http://autobuild.buildroot.net/results/a9b/a9b5209377acb51e69f376e0c008ee71fe00397a/
> http://autobuild.buildroot.net/results/55f/55fe22463d49addb42b635d10be5176522f4a561/
> http://autobuild.buildroot.net/results/808/808acca0cfed93465845c2aa055a7a4fc56a8a17/
> http://autobuild.buildroot.net/results/b92/b92a9c84b71a8a2d022d307245ca6be36a000e6c/
> http://autobuild.buildroot.net/results/55d/55df698ab53f7d94235166e8576eb681ed68668e/
> .. and more.
> Upstream status: Pending
> https://github.com/lloyd/yajl/pull/187
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> ---
> Changes v1 -> v2:
> - conditionally link gen-extra-close against the shared libyajl in a shared
> build and against the static libyajl otherwise (Samuel Martin)
> - apply this to all other build targets linking against yajl
Committed, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2016-04-15 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-09 22:15 [Buildroot] [PATCH v2] yajl: fix static linking in a parallel build Jörg Krause
2016-04-10 18:39 ` Arnout Vandecappelle
2016-04-15 18:27 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ffyhgn0.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.