From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 3/5] drm/i915: Harden detection of missed interrupts Date: Tue, 16 Feb 2016 14:51:48 +0200 Message-ID: <877fi4rf6j.fsf@gaia.fi.intel.com> References: <1455623268-10023-1-git-send-email-chris@chris-wilson.co.uk> <1455623268-10023-4-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 1EEEA6E7C9 for ; Tue, 16 Feb 2016 12:53:41 +0000 (UTC) In-Reply-To: <1455623268-10023-4-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gT25seSBk ZWNsYXJlIGEgbWlzc2VkIGludGVycnVwdCBpZiB3ZSBmaW5kIHRoYXQgdGhlIEdQVSBpcyBpZGxl IHdpdGgKPiB3YWl0ZXJzIGFuZCBhIGhhbmdjaGVjayBpbnRlcnZhbCBoYXMgcGFzc2VkIGluIHdo aWNoIG5vIG5ldyB1c2VyCj4gaW50ZXJydXB0cyBoYXZlIGJlZW4gcmFpc2VkLgo+Cj4gdjI6IENs ZWFyIHRoZSBzdHVjayBpbnRlcnJ1cHQgbWFya2VyIGJldHdlZW4gc3VjY2Vzc2Z1bCBiYXRjaGVz Cj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51 az4KPiBDYzogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBpbnRlbC5jb20+CgpSZXZpZXdl ZC1ieTogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBpbnRlbC5jb20+Cgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyAgICAgfCAxMSArKysrKysrLS0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jICAgICAgICAgfCAxMCArKysrKysrKyst Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaCB8ICAyICsrCj4gIDMg ZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPgo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gaW5kZXggYzRkZjU4MGVkMGRlLi5mM2JhOTdhZDNl MDAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+IEBAIC03MzAsMTAgKzcz MCwxMCBAQCBzdGF0aWMgaW50IGk5MTVfZ2VtX3JlcXVlc3RfaW5mbyhzdHJ1Y3Qgc2VxX2ZpbGUg Km0sIHZvaWQgKmRhdGEpCj4gIHN0YXRpYyB2b2lkIGk5MTVfcmluZ19zZXFub19pbmZvKHN0cnVj dCBzZXFfZmlsZSAqbSwKPiAgCQkJCSBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nKQo+ICB7 Cj4gLQlpZiAocmluZy0+Z2V0X3NlcW5vKSB7Cj4gLQkJc2VxX3ByaW50ZihtLCAiQ3VycmVudCBz ZXF1ZW5jZSAoJXMpOiAleFxuIiwKPiAtCQkJICAgcmluZy0+bmFtZSwgcmluZy0+Z2V0X3NlcW5v KHJpbmcpKTsKPiAtCX0KPiArCXNlcV9wcmludGYobSwgIkN1cnJlbnQgc2VxdWVuY2UgKCVzKTog JXhcbiIsCj4gKwkJICAgcmluZy0+bmFtZSwgcmluZy0+Z2V0X3NlcW5vKHJpbmcpKTsKPiArCXNl cV9wcmludGYobSwgIkN1cnJlbnQgdXNlciBpbnRlcnJ1cHRzICglcyk6ICV4XG4iLAo+ICsJCSAg IHJpbmctPm5hbWUsIFJFQURfT05DRShyaW5nLT51c2VyX2ludGVycnVwdHMpKTsKPiAgfQo+ICAK PiAgc3RhdGljIGludCBpOTE1X2dlbV9zZXFub19pbmZvKHN0cnVjdCBzZXFfZmlsZSAqbSwgdm9p ZCAqZGF0YSkKPiBAQCAtMTM2MSw2ICsxMzYxLDkgQEAgc3RhdGljIGludCBpOTE1X2hhbmdjaGVj a19pbmZvKHN0cnVjdCBzZXFfZmlsZSAqbSwgdm9pZCAqdW51c2VkKQo+ICAJCXNlcV9wcmludGYo bSwgIiVzOlxuIiwgcmluZy0+bmFtZSk7Cj4gIAkJc2VxX3ByaW50ZihtLCAiXHRzZXFubyA9ICV4 IFtjdXJyZW50ICV4XVxuIiwKPiAgCQkJICAgcmluZy0+aGFuZ2NoZWNrLnNlcW5vLCBzZXFub1tp XSk7Cj4gKwkJc2VxX3ByaW50ZihtLCAiXHR1c2VyIGludGVycnVwdHMgPSAleCBbY3VycmVudCAl eF1cbiIsCj4gKwkJCSAgIHJpbmctPmhhbmdjaGVjay51c2VyX2ludGVycnVwdHMsCj4gKwkJCSAg IHJpbmctPnVzZXJfaW50ZXJydXB0cyk7Cj4gIAkJc2VxX3ByaW50ZihtLCAiXHRBQ1RIRCA9IDB4 JTA4bGx4IFtjdXJyZW50IDB4JTA4bGx4XVxuIiwKPiAgCQkJICAgKGxvbmcgbG9uZylyaW5nLT5o YW5nY2hlY2suYWN0aGQsCj4gIAkJCSAgIChsb25nIGxvbmcpYWN0aGRbaV0pOwo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9pcnEuYwo+IGluZGV4IDA3YmMyY2RkNjI1Mi4uYzBhZWZmNjA3MTMwIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gQEAgLTEwMDAsNiArMTAwMCw3IEBAIHN0YXRpYyB2b2lk IG5vdGlmeV9yaW5nKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmcpCj4gIAkJcmV0dXJuOwo+ ICAKPiAgCXRyYWNlX2k5MTVfZ2VtX3JlcXVlc3Rfbm90aWZ5KHJpbmcpOwo+ICsJcmluZy0+dXNl cl9pbnRlcnJ1cHRzKys7Cj4gIAo+ICAJd2FrZV91cF9hbGwoJnJpbmctPmlycV9xdWV1ZSk7Cj4g IH0KPiBAQCAtMzA5Nyw2ICszMDk4LDcgQEAgc3RhdGljIHZvaWQgaTkxNV9oYW5nY2hlY2tfZWxh cHNlZChzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCj4gIAlmb3JfZWFjaF9yaW5nKHJpbmcsIGRl dl9wcml2LCBpKSB7Cj4gIAkJdTY0IGFjdGhkOwo+ICAJCXUzMiBzZXFubzsKPiArCQl1bnNpZ25l ZCB1c2VyX2ludGVycnVwdHM7Cj4gIAkJYm9vbCBidXN5ID0gdHJ1ZTsKPiAgCj4gIAkJc2VtYXBo b3JlX2NsZWFyX2RlYWRsb2NrcyhkZXZfcHJpdik7Cj4gQEAgLTMxMTMsNiArMzExNSw3IEBAIHN0 YXRpYyB2b2lkIGk5MTVfaGFuZ2NoZWNrX2VsYXBzZWQoc3RydWN0IHdvcmtfc3RydWN0ICp3b3Jr KQo+ICAKPiAgCQlhY3RoZCA9IGludGVsX3JpbmdfZ2V0X2FjdGl2ZV9oZWFkKHJpbmcpOwo+ICAJ CXNlcW5vID0gcmluZy0+Z2V0X3NlcW5vKHJpbmcpOwo+ICsJCXVzZXJfaW50ZXJydXB0cyA9IFJF QURfT05DRShyaW5nLT51c2VyX2ludGVycnVwdHMpOwo+ICAKPiAgCQlpZiAocmluZy0+aGFuZ2No ZWNrLnNlcW5vID09IHNlcW5vKSB7Cj4gIAkJCWlmIChyaW5nX2lkbGUocmluZywgc2Vxbm8pKSB7 Cj4gQEAgLTMxMjAsNyArMzEyMyw4IEBAIHN0YXRpYyB2b2lkIGk5MTVfaGFuZ2NoZWNrX2VsYXBz ZWQoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ICAKPiAgCQkJCWlmICh3YWl0cXVldWVfYWN0 aXZlKCZyaW5nLT5pcnFfcXVldWUpKSB7Cj4gIAkJCQkJLyogSXNzdWUgYSB3YWtlLXVwIHRvIGNh dGNoIHN0dWNrIGgvdy4gKi8KPiAtCQkJCQlpZiAoIXRlc3RfYW5kX3NldF9iaXQocmluZy0+aWQs ICZkZXZfcHJpdi0+Z3B1X2Vycm9yLm1pc3NlZF9pcnFfcmluZ3MpKSB7Cj4gKwkJCQkJaWYgKHJp bmctPmhhbmdjaGVjay51c2VyX2ludGVycnVwdHMgPT0gdXNlcl9pbnRlcnJ1cHRzICYmCj4gKwkJ CQkJICAgICF0ZXN0X2FuZF9zZXRfYml0KHJpbmctPmlkLCAmZGV2X3ByaXYtPmdwdV9lcnJvci5t aXNzZWRfaXJxX3JpbmdzKSkgewo+ICAJCQkJCQlpZiAoIShkZXZfcHJpdi0+Z3B1X2Vycm9yLnRl c3RfaXJxX3JpbmdzICYgaW50ZWxfcmluZ19mbGFnKHJpbmcpKSkKPiAgCQkJCQkJCURSTV9FUlJP UigiSGFuZ2NoZWNrIHRpbWVyIGVsYXBzZWQuLi4gJXMgaWRsZVxuIiwKPiAgCQkJCQkJCQkgIHJp bmctPm5hbWUpOwo+IEBAIC0zMTgzLDEwICszMTg3LDE0IEBAIHN0YXRpYyB2b2lkIGk5MTVfaGFu Z2NoZWNrX2VsYXBzZWQoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ICAKPiAgCQkJbWVtc2V0 KHJpbmctPmhhbmdjaGVjay5pbnN0ZG9uZSwgMCwKPiAgCQkJICAgICAgIHNpemVvZihyaW5nLT5o YW5nY2hlY2suaW5zdGRvbmUpKTsKPiArCj4gKwkJCS8qIFJlc2V0IHN0dWNrIGludGVycnVwdHMg YmV0d2VlbiBiYXRjaCBhZHZhbmNlcyAqLwo+ICsJCQl1c2VyX2ludGVycnVwdHMgPSAwOwo+ICAJ CX0KPiAgCj4gIAkJcmluZy0+aGFuZ2NoZWNrLnNlcW5vID0gc2Vxbm87Cj4gIAkJcmluZy0+aGFu Z2NoZWNrLmFjdGhkID0gYWN0aGQ7Cj4gKwkJcmluZy0+aGFuZ2NoZWNrLnVzZXJfaW50ZXJydXB0 cyA9IHVzZXJfaW50ZXJydXB0czsKPiAgCQlidXN5X2NvdW50ICs9IGJ1c3k7Cj4gIAl9Cj4gIAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmggYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmgKPiBpbmRleCA0Y2VhMDQ0OTEz OTIuLmRmYjE0YmZlNWJjOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9yaW5nYnVmZmVyLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVm ZmVyLmgKPiBAQCAtOTAsNiArOTAsNyBAQCBzdHJ1Y3QgaW50ZWxfcmluZ19oYW5nY2hlY2sgewo+ ICAJdTY0IGFjdGhkOwo+ICAJdTY0IG1heF9hY3RoZDsKPiAgCXUzMiBzZXFubzsKPiArCXVuc2ln bmVkIHVzZXJfaW50ZXJydXB0czsKPiAgCWludCBzY29yZTsKPiAgCWVudW0gaW50ZWxfcmluZ19o YW5nY2hlY2tfYWN0aW9uIGFjdGlvbjsKPiAgCWludCBkZWFkbG9jazsKPiBAQCAtMzA2LDYgKzMw Nyw3IEBAIHN0cnVjdCAgaW50ZWxfZW5naW5lX2NzIHsKPiAgCSAqIGluc3BlY3RpbmcgcmVxdWVz dCBsaXN0Lgo+ICAJICovCj4gIAl1MzIgbGFzdF9zdWJtaXR0ZWRfc2Vxbm87Cj4gKwl1bnNpZ25l ZCB1c2VyX2ludGVycnVwdHM7Cj4gIAo+ICAJYm9vbCBncHVfY2FjaGVzX2RpcnR5Owo+ICAKPiAt LSAKPiAyLjcuMApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK