From: Markus Armbruster <armbru@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Marcel Apfelbaum <marcel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
lersek@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/4] Error location reporting fixes
Date: Mon, 15 Feb 2016 11:33:03 +0100 [thread overview]
Message-ID: <877fi65km8.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1455303747-19776-1-git-send-email-ehabkost@redhat.com> (Eduardo Habkost's message of "Fri, 12 Feb 2016 17:02:23 -0200")
Eduardo Habkost <ehabkost@redhat.com> writes:
> This fixes the following bugs in error reporting:
>
> $ qemu-system-x86_64 -icount rr=x -vnc :0
> qemu-system-x86_64: -vnc :0: Invalid icount rr option: x
>
> $ qemu-system-x86_64 -m size= -vnc :0
> qemu-system-x86_64: -vnc :0: missing 'size' option value
>
> The last command-line option (-vnc) is being shown in the error
> message, instead of the -m or -icount options.
>
> This also includes a patch submitted previously by Marcel, to
> ensure there are no ordering conflicts when applying the patches.
> Marcel's patch fixes the following bug:
>
> $ qemu-system-x86_64 -M q35-1.5 -redir tcp:8022::22
> qemu-system-x86_64: -redir tcp:8022::22: unsupported machine type
> Use -machine help to list supported machines
I have two minor suggestions. Regardless:
Reviewed-by: Markus Armbruster <armbru@redhat.com>
I can take the series through my tree. Of course, Paolo merging it
through his would also be fine.
next prev parent reply other threads:[~2016-02-15 10:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 19:02 [Qemu-devel] [PATCH v2 0/4] Error location reporting fixes Eduardo Habkost
2016-02-12 19:02 ` [Qemu-devel] [PATCH v2 1/4] vl.c: Fix regression in machine error message Eduardo Habkost
2016-02-15 10:20 ` Markus Armbruster
2016-02-15 10:54 ` Marcel Apfelbaum
2016-02-15 11:53 ` Laszlo Ersek
2016-02-15 14:30 ` Markus Armbruster
2016-02-16 12:46 ` Markus Armbruster
2016-02-12 19:02 ` [Qemu-devel] [PATCH v2 2/4] vl: Reset location after handling command-line arguments Eduardo Habkost
2016-02-12 19:34 ` Marcel Apfelbaum
2016-02-15 10:29 ` Markus Armbruster
2016-02-15 15:22 ` Eduardo Habkost
2016-02-12 19:02 ` [Qemu-devel] [PATCH v2 3/4] replay: Set error location properly when parsing options Eduardo Habkost
2016-02-12 19:34 ` Marcel Apfelbaum
2016-02-12 19:02 ` [Qemu-devel] [PATCH v2 4/4] vl: Set error location when parsing memory options Eduardo Habkost
2016-02-12 19:35 ` Marcel Apfelbaum
2016-02-15 10:33 ` Markus Armbruster [this message]
2016-02-16 14:57 ` [Qemu-devel] [PATCH 5/4] vl: Clean up machine selection in main() Markus Armbruster
2016-02-16 15:34 ` Laszlo Ersek
2016-02-16 19:56 ` Markus Armbruster
2016-02-16 16:27 ` Marcel Apfelbaum
2016-02-16 19:52 ` Markus Armbruster
2016-02-16 20:03 ` [Qemu-devel] [PATCH v2 0/4] Error location reporting fixes Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fi65km8.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=lersek@redhat.com \
--cc=marcel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.