From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54497) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQWQM-0001Ko-6O for qemu-devel@nongnu.org; Tue, 02 Feb 2016 03:34:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQWQI-0001YL-UN for qemu-devel@nongnu.org; Tue, 02 Feb 2016 03:34:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50730) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQWQI-0001YH-Oo for qemu-devel@nongnu.org; Tue, 02 Feb 2016 03:34:54 -0500 From: Markus Armbruster References: <1454343639-9020-1-git-send-email-marcandre.lureau@redhat.com> <1454343639-9020-8-git-send-email-marcandre.lureau@redhat.com> Date: Tue, 02 Feb 2016 09:34:52 +0100 In-Reply-To: <1454343639-9020-8-git-send-email-marcandre.lureau@redhat.com> (marcandre lureau's message of "Mon, 1 Feb 2016 17:20:38 +0100") Message-ID: <877finv7bn.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 7/8] ivshmem: use a single eventfd callback, get rid of CharDriver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com Cc: claudio.fontana@huawei.com, qemu-devel@nongnu.org marcandre.lureau@redhat.com writes: > From: Marc-Andr=C3=A9 Lureau > > Simplify the interrupt handling by having a single callback on irq&msi > cases. Remove usage of CharDriver, replace it with > qemu_set_fd_handler(). Use event_notifier_test_and_clear() to read the > eventfd. > > Before this patch, ivshmem writes the first byte received to > s->intrstatus. But ivshmem_device_spec.txt says "The status register is > set to 1 when an interrupt occurs." Suggest to add: Fortunately, the byte usually comes from another ivshmem device, and those always write 1. > After this commit, follows the > specification, set to 1 when an interrupt occurs. > > Signed-off-by: Marc-Andr=C3=A9 Lureau Acked-by: Markus Armbruster