From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59607)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1aHE0t-0006Bd-0s
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:06:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1aHE0o-0005TR-R0
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:06:14 -0500
Received: from e28smtp01.in.ibm.com ([125.16.236.1]:55228)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1aHE0o-0005SQ-50
	for qemu-devel@nongnu.org; Thu, 07 Jan 2016 12:06:10 -0500
Received: from localhost
	by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aneesh.kumar@linux.vnet.ibm.com>;
	Thu, 7 Jan 2016 22:36:07 +0530
Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58])
	by d28dlp02.in.ibm.com (Postfix) with ESMTP id 1CD75394005E
	for <qemu-devel@nongnu.org>; Thu,  7 Jan 2016 22:36:06 +0530 (IST)
Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64])
	by d28relay01.in.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id
	u07H64kb8323076
	for <qemu-devel@nongnu.org>; Thu, 7 Jan 2016 22:36:04 +0530
Received: from d28av02.in.ibm.com (localhost [127.0.0.1])
	by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	u07H631Q009621
	for <qemu-devel@nongnu.org>; Thu, 7 Jan 2016 22:36:04 +0530
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
In-Reply-To: <20160107133243.509cc369@bahia.local>
References: <1452020761-24457-1-git-send-email-wei.liu2@citrix.com>
	<alpine.DEB.2.02.1601071155260.13564@kaball.uk.xensource.com>
	<20160107133243.509cc369@bahia.local>
Date: Thu, 07 Jan 2016 22:36:02 +0530
Message-ID: <877fjlqpz9.fsf@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 00/22] 9pfs: disentangling virtio and
	generic code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

Greg Kurz <gkurz@linux.vnet.ibm.com> writes:

> On Thu, 7 Jan 2016 11:59:22 +0000
> Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:
>
>> On Tue, 5 Jan 2016, Wei Liu wrote:
>> > Hi all
>> > 
>> > Back in 2015 summer one of our OPW interns Linda Jacobson explored the
>> > possibility of making 9pfs work on Xen. It turned out lots of code in QEMU can
>> > be reused.
>> > 
>> > This series refactors 9pfs related code:
>> > 
>> > 1. Rename a bunch of files and functions to make clear they are generic.
>> > 2. Only export two functions (marshal and unmarshal) from transport to generic
>> >    code.
>> > 3. disentangle virtio transport code and generic 9pfs code.
>> > 4. Some function name clean-up.
>> 
>> The series looks pretty good and it looks like a clean improvement over
>> the current code base.
>> 
>
> I agree Wei did a great job. I'll fix the title in patch 3 and push it to
> my tree next week.
>

I will like to push this myself. I will need some time to get some
testing done with the changes. We also need some fixup with respect to fd
reclaim.

-aneesh