From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v3 2/5] drm/dsi: Try to match non-DT dsi devices Date: Mon, 07 Dec 2015 11:10:07 +0200 Message-ID: <877fkqzksw.fsf@intel.com> References: <201511302050.evPZc1zs%fengguang.wu@intel.com> <56651937.1080405@codeaurora.org> <87a8pmzly4.fsf@intel.com> <56654A86.1060602@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <56654A86.1060602@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Archit Taneja , dri-devel@lists.freedesktop.org, daniel@ffwll.ch Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, a.hajda@samsung.com, treding@nvidia.com List-Id: linux-arm-msm@vger.kernel.org T24gTW9uLCAwNyBEZWMgMjAxNSwgQXJjaGl0IFRhbmVqYSA8YXJjaGl0dEBjb2RlYXVyb3JhLm9y Zz4gd3JvdGU6Cj4gT24gMTIvMDcvMjAxNSAwMjoxNSBQTSwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4+ IE9uIE1vbiwgMDcgRGVjIDIwMTUsIEFyY2hpdCBUYW5lamEgPGFyY2hpdHRAY29kZWF1cm9yYS5v cmc+IHdyb3RlOgo+Pj4gSGksCj4+Pgo+Pj4gT24gMTEvMzAvMjAxNSAwNjoxNSBQTSwga2J1aWxk IHRlc3Qgcm9ib3Qgd3JvdGU6Cj4+Pj4gSGkgQXJjaGl0LAo+Pj4+Cj4+Pj4gW2F1dG8gYnVpbGQg dGVzdCBFUlJPUiBvbjogdjQuNC1yYzNdCj4+Pj4gW2Fsc28gYnVpbGQgdGVzdCBFUlJPUiBvbjog bmV4dC0yMDE1MTEyN10KPj4+Pgo+Pj4+IHVybDogICAgaHR0cHM6Ly9naXRodWIuY29tLzBkYXkt Y2kvbGludXgvY29tbWl0cy9BcmNoaXQtVGFuZWphL2RybS1kc2ktRFNJLWZvci1kZXZpY2VzLXdp dGgtZGlmZmVyZW50LWNvbnRyb2wtYnVzLzIwMTUxMTMwLTIwMDcyNQo+Pj4+IGNvbmZpZzogeDg2 XzY0LWFsbHllc2RlYmlhbiAoYXR0YWNoZWQgYXMgLmNvbmZpZykKPj4+PiByZXByb2R1Y2U6Cj4+ Pj4gICAgICAgICAgICMgc2F2ZSB0aGUgYXR0YWNoZWQgLmNvbmZpZyB0byBsaW51eCBidWlsZCB0 cmVlCj4+Pj4gICAgICAgICAgIG1ha2UgQVJDSD14ODZfNjQKPj4+Pgo+Pj4+IEFsbCBlcnJvcnMg KG5ldyBvbmVzIHByZWZpeGVkIGJ5ID4+KToKPj4+Pgo+Pj4+ICAgICAgZHJpdmVycy9ncHUvZHJt L2RybV9taXBpX2RzaS5jOiBJbiBmdW5jdGlvbiAnb2ZfbWlwaV9kc2lfZGV2aWNlX2FkZCc6Cj4+ Pj4+PiBkcml2ZXJzL2dwdS9kcm0vZHJtX21pcGlfZHNpLmM6MTY4OjY6IGVycm9yOiBpbXBsaWNp dCBkZWNsYXJhdGlvbiBvZiBmdW5jdGlvbiAnb2ZfbW9kYWxpYXNfbm9kZScgWy1XZXJyb3I9aW1w bGljaXQtZnVuY3Rpb24tZGVjbGFyYXRpb25dCj4+Pj4gICAgICAgIGlmIChvZl9tb2RhbGlhc19u b2RlKG5vZGUsIGluZm8udHlwZSwgc2l6ZW9mKGluZm8udHlwZSkpIDwgMCkgewo+Pj4KPj4+IEFu eSBzdWdnZXN0aW9ucyBvbiBob3cgdG8gZml4IHRoaXM/IElzIGl0IG9rIHRvIG1ha2UgRFJNX01J UElfRFNJCj4+PiBkZXBlbmQgb24gQ09ORklHX09GPwo+Pgo+PiBQbGVhc2UgZG9uJ3QuCj4KPiBK dXN0IGN1cmlvdXMsIGhvdyBkaWQgeDg2IHVzZSBEU0kgaWYgdGhlIG9ubHkgd2F5IHRvIGNyZWF0 ZSBEU0kgZGV2aWNlcwo+IHVudGlsIG5vdyB3YXMgdmlhIERUPwoKT2gsIHlvdSB3YW50IHRoZSBn b3J5IGRldGFpbHMuLi4gd2UgdXNlIHRoZSBEU0kgY29kZSBhcyBhIGxpYnJhcnkgZm9yCmFic3Ry YWN0aW9uIGFuZCBoZWxwZXJzLCB3aXRob3V0IGFjdHVhbGx5IGNyZWF0aW5nIG9yIHJlZ2lzdGVy aW5nIHRoZQpkZXZpY2VzLgoKQlIsCkphbmkuCgoKPgo+IEFyY2hpdAo+Cj4+Cj4+IEJSLAo+PiBK YW5pLgo+PgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENl bnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755415AbbLGJKP (ORCPT ); Mon, 7 Dec 2015 04:10:15 -0500 Received: from mga14.intel.com ([192.55.52.115]:61183 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755240AbbLGJKM (ORCPT ); Mon, 7 Dec 2015 04:10:12 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,394,1444719600"; d="scan'208";a="868170906" From: Jani Nikula To: Archit Taneja , dri-devel@lists.freedesktop.org, daniel@ffwll.ch Cc: a.hajda@samsung.com, linux-kernel@vger.kernel.org, airlied@linux.ie, treding@nvidia.com, l.stach@pengutronix.de, robh@kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v3 2/5] drm/dsi: Try to match non-DT dsi devices In-Reply-To: <56654A86.1060602@codeaurora.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <201511302050.evPZc1zs%fengguang.wu@intel.com> <56651937.1080405@codeaurora.org> <87a8pmzly4.fsf@intel.com> <56654A86.1060602@codeaurora.org> User-Agent: Notmuch/0.20.2+101~gb57168b (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Mon, 07 Dec 2015 11:10:07 +0200 Message-ID: <877fkqzksw.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 07 Dec 2015, Archit Taneja wrote: > On 12/07/2015 02:15 PM, Jani Nikula wrote: >> On Mon, 07 Dec 2015, Archit Taneja wrote: >>> Hi, >>> >>> On 11/30/2015 06:15 PM, kbuild test robot wrote: >>>> Hi Archit, >>>> >>>> [auto build test ERROR on: v4.4-rc3] >>>> [also build test ERROR on: next-20151127] >>>> >>>> url: https://github.com/0day-ci/linux/commits/Archit-Taneja/drm-dsi-DSI-for-devices-with-different-control-bus/20151130-200725 >>>> config: x86_64-allyesdebian (attached as .config) >>>> reproduce: >>>> # save the attached .config to linux build tree >>>> make ARCH=x86_64 >>>> >>>> All errors (new ones prefixed by >>): >>>> >>>> drivers/gpu/drm/drm_mipi_dsi.c: In function 'of_mipi_dsi_device_add': >>>>>> drivers/gpu/drm/drm_mipi_dsi.c:168:6: error: implicit declaration of function 'of_modalias_node' [-Werror=implicit-function-declaration] >>>> if (of_modalias_node(node, info.type, sizeof(info.type)) < 0) { >>> >>> Any suggestions on how to fix this? Is it ok to make DRM_MIPI_DSI >>> depend on CONFIG_OF? >> >> Please don't. > > Just curious, how did x86 use DSI if the only way to create DSI devices > until now was via DT? Oh, you want the gory details... we use the DSI code as a library for abstraction and helpers, without actually creating or registering the devices. BR, Jani. > > Archit > >> >> BR, >> Jani. >> -- Jani Nikula, Intel Open Source Technology Center