From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1a2Kl6-00061x-Uz for mharc-qemu-trivial@gnu.org; Fri, 27 Nov 2015 10:16:25 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2Kl3-0005yI-Uh for qemu-trivial@nongnu.org; Fri, 27 Nov 2015 10:16:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2Kl2-0007BW-W0 for qemu-trivial@nongnu.org; Fri, 27 Nov 2015 10:16:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2Kky-00079g-EY; Fri, 27 Nov 2015 10:16:16 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id B70C5C057F9E; Fri, 27 Nov 2015 15:16:15 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-61.ams2.redhat.com [10.36.116.61]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tARFGDCR025062 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 27 Nov 2015 10:16:15 -0500 Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 3D3A7303F16C; Fri, 27 Nov 2015 16:16:13 +0100 (CET) From: Markus Armbruster To: Paolo Bonzini References: <1448626105-29540-1-git-send-email-pbonzini@redhat.com> <87oaefzeuh.fsf@blackfin.pond.sub.org> <56586B7D.2040205@redhat.com> Date: Fri, 27 Nov 2015 16:16:13 +0100 In-Reply-To: <56586B7D.2040205@redhat.com> (Paolo Bonzini's message of "Fri, 27 Nov 2015 15:41:01 +0100") Message-ID: <877fl3v5fm.fsf@blackfin.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2015 15:16:22 -0000 Paolo Bonzini writes: > On 27/11/2015 15:39, Markus Armbruster wrote: >> Since you also fix RESET_FAILED_CONTACT_COUNTER_RP_SIZE, I assume you >> checked them all. >> >> Reviewed-by: Markus Armbruster > > No, I just copied the upstream bluez patch. At least CREATE_CONN_CANCEL_CP_SIZE is also wrong. Any particular reason not to mass-convert to sizeof and call it a day? From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38662) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2Kl2-0005wX-6U for qemu-devel@nongnu.org; Fri, 27 Nov 2015 10:16:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2Kky-0007AF-JL for qemu-devel@nongnu.org; Fri, 27 Nov 2015 10:16:20 -0500 From: Markus Armbruster References: <1448626105-29540-1-git-send-email-pbonzini@redhat.com> <87oaefzeuh.fsf@blackfin.pond.sub.org> <56586B7D.2040205@redhat.com> Date: Fri, 27 Nov 2015 16:16:13 +0100 In-Reply-To: <56586B7D.2040205@redhat.com> (Paolo Bonzini's message of "Fri, 27 Nov 2015 15:41:01 +0100") Message-ID: <877fl3v5fm.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH for-2.5] bt: fix two struct sizes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Paolo Bonzini writes: > On 27/11/2015 15:39, Markus Armbruster wrote: >> Since you also fix RESET_FAILED_CONTACT_COUNTER_RP_SIZE, I assume you >> checked them all. >> >> Reviewed-by: Markus Armbruster > > No, I just copied the upstream bluez patch. At least CREATE_CONN_CANCEL_CP_SIZE is also wrong. Any particular reason not to mass-convert to sizeof and call it a day?