From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50822)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Zs4np-0003TU-MV
	for qemu-devel@nongnu.org; Fri, 30 Oct 2015 04:12:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Zs4nm-0004my-Gu
	for qemu-devel@nongnu.org; Fri, 30 Oct 2015 04:12:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49336)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Zs4nm-0004mu-As
	for qemu-devel@nongnu.org; Fri, 30 Oct 2015 04:12:46 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1446129134-26379-1-git-send-email-armbru@redhat.com>
	<CAFEAcA82u-zUNo7ysWFrD+ASmF5P9F9D27vY_AjmZN_pBTuMAA@mail.gmail.com>
Date: Fri, 30 Oct 2015 09:12:43 +0100
In-Reply-To: <CAFEAcA82u-zUNo7ysWFrD+ASmF5P9F9D27vY_AjmZN_pBTuMAA@mail.gmail.com>
	(Peter Maydell's message of "Thu, 29 Oct 2015 17:27:50 +0000")
Message-ID: <877fm4pyf8.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PULL v3 00/14] QMP and QObject patches
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Peter Maydell <peter.maydell@linaro.org> writes:

> On 29 October 2015 at 14:32, Markus Armbruster <armbru@redhat.com> wrote:
>> The following changes since commit 7bc8e0c967a4ef77657174d28af775691e18b4ce:
>>
>>   Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into
>> staging (2015-10-29 09:49:52 +0000)
>>
>> are available in the git repository at:
>>
>>   git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2015-10-29
>>
>> for you to fetch changes up to f6724b5b1b8fb1ca76b3df10d80415c206e2c4b9:
>>
>>   docs: Document QMP event rate limiting (2015-10-29 14:37:34 +0100)
>>
>> ----------------------------------------------------------------
>> QMP and QObject patches
>>
>
> Still doesn't build with old glib:
>
> In file included from /Users/pm215/src/qemu-for-merges/qga/commands.c:14:
> In file included from
> /Users/pm215/src/qemu-for-merges/qga/guest-agent-core.h:14:
> In file included from /Users/pm215/src/qemu-for-merges/include/qemu-common.h:25:
> /Users/pm215/src/qemu-for-merges/include/glib-compat.h:172:47: error:
> expected ';' after expression
>     g_hash_table_replace(hash_table, key, key)
>                                               ^
>                                               ;
>
> I did a trial build with the typo fixed, and that is OK, so this
> should be the last fix required, I think.

I fixed up this line, pushed, and sent a PULL v4 cover letter.  Sorry
for the extra iterations.