From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: fix compiler warnings in intel_audio.c Date: Wed, 30 Sep 2015 17:35:59 +0300 Message-ID: <877fn8c6uo.fsf@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , David Airlie Cc: Geliang Tang , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAzMCBTZXAgMjAxNSwgR2VsaWFuZyBUYW5nIDxnZWxpYW5ndGFuZ0AxNjMuY29tPiB3 cm90ZToKPiBGaXggdGhlIGZvbGxvd2luZyB3YXJuaW5nczoKPgo+ICAgQ0MgICAgICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9hdWRpby5vCj4gZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf YXVkaW8uYzogSW4gZnVuY3Rpb24g4oCYaHN3X2F1ZGlvX2NvZGVjX2VuYWJsZeKAmToKPiBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdWRpby5jOjMzMjozOTogd2FybmluZzogcGFzc2luZyBh cmd1bWVudCAyIG9mIOKAmGF1ZGlvX3JhdGVfbmVlZF9wcm9n4oCZIGRpc2NhcmRzIOKAmGNvbnN0 4oCZIHF1YWxpZmllciBmcm9tIHBvaW50ZXIgdGFyZ2V0IHR5cGUgWy1XZGlzY2FyZGVkLXF1YWxp ZmllcnNdCj4gICBpZiAoYXVkaW9fcmF0ZV9uZWVkX3Byb2coaW50ZWxfY3J0YywgYWRqdXN0ZWRf bW9kZSkpIHsKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBeCj4gZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXVkaW8uYzoxNDc6MTM6IG5vdGU6IGV4cGVjdGVkIOKA mHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICrigJkgYnV0IGFyZ3VtZW50IGlzIG9mIHR5cGUg4oCY Y29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKuKAmQo+ICBzdGF0aWMgYm9vbCBhdWRpb19y YXRlX25lZWRfcHJvZyhzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiAgICAgICAgICAgICAgXgoK QWxyZWFkeSBmaXhlZCBieSBUYWthc2hpOgoKaHR0cDovL21pZC5nbWFuZS5vcmcvMTQ0MzU5OTEw My0yNjMxNy0xLWdpdC1zZW5kLWVtYWlsLXRpd2FpQHN1c2UuZGUKClRoYW5rcyBhbnl3YXksCkph bmkuCgoKPgo+IFNpZ25lZC1vZmYtYnk6IEdlbGlhbmcgVGFuZyA8Z2VsaWFuZ3RhbmdAMTYzLmNv bT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXVkaW8uYyB8IDIgKy0KPiAg MSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4KPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXVkaW8uYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2F1ZGlvLmMKPiBpbmRleCBiYWFkZDkwLi43MmQ2OTZiIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F1ZGlvLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9hdWRpby5jCj4gQEAgLTE0NSw3ICsxNDUsNyBAQCBzdGF0aWMgdWlu dDMyX3QgYXVkaW9fY29uZmlnX3NldHVwX25fcmVnKGludCBuLCB1aW50MzJfdCB2YWwpCj4gIAo+ ICAvKiBjaGVjayB3aGV0aGVyIE4vQ1RTL00gbmVlZCBiZSBzZXQgbWFudWFsbHkgKi8KPiAgc3Rh dGljIGJvb2wgYXVkaW9fcmF0ZV9uZWVkX3Byb2coc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4g LQkJCQkJc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUpCj4gKwkJCQkgY29uc3Qgc3RydWN0 IGRybV9kaXNwbGF5X21vZGUgKm1vZGUpCj4gIHsKPiAgCWlmICgoKG1vZGUtPmNsb2NrID09IFRN RFNfMjk3TSkgfHwKPiAgCQkgKG1vZGUtPmNsb2NrID09IFRNRFNfMjk2TSkpICYmCj4gLS0gCj4g Mi41LjAKPgo+CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kg Q2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754125AbbI3Oco (ORCPT ); Wed, 30 Sep 2015 10:32:44 -0400 Received: from mga09.intel.com ([134.134.136.24]:27980 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753699AbbI3Ocl convert rfc822-to-8bit (ORCPT ); Wed, 30 Sep 2015 10:32:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,612,1437462000"; d="scan'208";a="816267328" From: Jani Nikula To: Geliang Tang , Daniel Vetter , David Airlie Cc: Geliang Tang , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/i915: fix compiler warnings in intel_audio.c In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: User-Agent: Notmuch/0.20.2+101~gb57168b (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Wed, 30 Sep 2015 17:35:59 +0300 Message-ID: <877fn8c6uo.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Sep 2015, Geliang Tang wrote: > Fix the following warnings: > > CC drivers/gpu/drm/i915/intel_audio.o > drivers/gpu/drm/i915/intel_audio.c: In function ‘hsw_audio_codec_enable’: > drivers/gpu/drm/i915/intel_audio.c:332:39: warning: passing argument 2 of ‘audio_rate_need_prog’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] > if (audio_rate_need_prog(intel_crtc, adjusted_mode)) { > ^ > drivers/gpu/drm/i915/intel_audio.c:147:13: note: expected ‘struct drm_display_mode *’ but argument is of type ‘const struct drm_display_mode *’ > static bool audio_rate_need_prog(struct intel_crtc *crtc, > ^ Already fixed by Takashi: http://mid.gmane.org/1443599103-26317-1-git-send-email-tiwai@suse.de Thanks anyway, Jani. > > Signed-off-by: Geliang Tang > --- > drivers/gpu/drm/i915/intel_audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c > index baadd90..72d696b 100644 > --- a/drivers/gpu/drm/i915/intel_audio.c > +++ b/drivers/gpu/drm/i915/intel_audio.c > @@ -145,7 +145,7 @@ static uint32_t audio_config_setup_n_reg(int n, uint32_t val) > > /* check whether N/CTS/M need be set manually */ > static bool audio_rate_need_prog(struct intel_crtc *crtc, > - struct drm_display_mode *mode) > + const struct drm_display_mode *mode) > { > if (((mode->clock == TMDS_297M) || > (mode->clock == TMDS_296M)) && > -- > 2.5.0 > > -- Jani Nikula, Intel Open Source Technology Center