From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: Re: [PATCH] x86/arm/mm: use gfn instead of pfn in
	p2m_get_mem_access/p2m_set_mem_access
Date: Tue, 23 Jun 2015 18:25:39 +0200
Message-ID: <877fqu8k8s.fsf@vitty.brq.redhat.com>
References: <1432647137-3515-1-git-send-email-vkuznets@redhat.com>
	<55649E1D020000780007DF5F@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55649E1D020000780007DF5F@mail.emea.novell.com> (Jan Beulich's
	message of "Tue, 26 May 2015 15:23:57 +0100")
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@citrix.com>, Tim Deegan <tim@xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Keir Fraser <keir@xen.org>, Jan Beulich <JBeulich@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

"Jan Beulich" <JBeulich@suse.com> writes:

>>>> On 26.05.15 at 15:32, <vkuznets@redhat.com> wrote:
>> --- a/xen/arch/arm/p2m.c
>> +++ b/xen/arch/arm/p2m.c
>> @@ -1709,9 +1709,9 @@ bool_t p2m_mem_access_check(paddr_t gpa, vaddr_t gla, 
>> const struct npfec npfec)
>>  
>>  /*
>>   * Set access type for a region of pfns.
>> - * If start_pfn == -1ul, sets the default access type.
>> + * If start_gfn == -1ul, sets the default access type.
>>   */
>> -long p2m_set_mem_access(struct domain *d, unsigned long pfn, uint32_t nr,
>> +long p2m_set_mem_access(struct domain *d, unsigned long start_gfn, uint32_t nr,
>>                          uint32_t start, uint32_t mask, xenmem_access_t access)
>>  {
>>      struct p2m_domain *p2m = p2m_get_hostp2m(d);
>> @@ -1752,14 +1752,15 @@ long p2m_set_mem_access(struct domain *d, unsigned long pfn, uint32_t nr,
>>      p2m->mem_access_enabled = true;
>>  
>>      /* If request to set default access. */
>> -    if ( pfn == ~0ul )
>> +    if ( start_gfn == ~0ul )
>>      {
>>          p2m->default_access = a;
>>          return 0;
>>      }
>>  
>>      rc = apply_p2m_changes(d, MEMACCESS,
>> -                           pfn_to_paddr(pfn+start), pfn_to_paddr(pfn+nr),
>> +                           pfn_to_paddr(start_gfn + start),
>
> Particularly due to this expression I'm not really happy about the
> start_ prefix that you're adding here, but I'll let the maintainers
> of the respective pieces of code decide if they're happy with it.

Sorry for the ping but it has been almost one month...

-- 
  Vitaly