All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: fix AP/IBSS CSA with template based fw
Date: Mon, 16 Feb 2015 15:21:53 +0200	[thread overview]
Message-ID: <877fvigff2.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQkZJLaAYy+PnoLiFn5S3sfJujgRRkWcMqgdxJbbf3FHeQ@mail.gmail.com> (Michal Kazior's message of "Mon, 16 Feb 2015 07:54:17 +0100")

Michal Kazior <michal.kazior@tieto.com> writes:

>> I actually had strange conflicts already with this patch (in mac.c). As
>> I'm travelling, please check my resolution from the pending branch very
>> carefully. I might have done something stupid.
>
> There's a mistake. Only `arvif->is_up` should be protected by
> `ar->data_lock` in ath10k_bss_assoc():
>
> @@ -1852,7 +1901,9 @@ static void ath10k_bss_assoc(struct ieee80211_hw *hw,
>                 return;
>         }
>
> +       spin_lock_bh(&arvif->ar->data_lock);
>         arvif->is_up = true;
> +       spin_unlock_bh(&arvif->ar->data_lock);
>
>         /* Workaround: Some firmware revisions (tested with qca6174

Thanks for catching this. I fixed it now, can you please check again?

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: fix AP/IBSS CSA with template based fw
Date: Mon, 16 Feb 2015 15:21:53 +0200	[thread overview]
Message-ID: <877fvigff2.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQkZJLaAYy+PnoLiFn5S3sfJujgRRkWcMqgdxJbbf3FHeQ@mail.gmail.com> (Michal Kazior's message of "Mon, 16 Feb 2015 07:54:17 +0100")

Michal Kazior <michal.kazior@tieto.com> writes:

>> I actually had strange conflicts already with this patch (in mac.c). As
>> I'm travelling, please check my resolution from the pending branch very
>> carefully. I might have done something stupid.
>
> There's a mistake. Only `arvif->is_up` should be protected by
> `ar->data_lock` in ath10k_bss_assoc():
>
> @@ -1852,7 +1901,9 @@ static void ath10k_bss_assoc(struct ieee80211_hw *hw,
>                 return;
>         }
>
> +       spin_lock_bh(&arvif->ar->data_lock);
>         arvif->is_up = true;
> +       spin_unlock_bh(&arvif->ar->data_lock);
>
>         /* Workaround: Some firmware revisions (tested with qca6174

Thanks for catching this. I fixed it now, can you please check again?

-- 
Kalle Valo

  reply	other threads:[~2015-02-16 13:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12 13:53 [PATCH] ath10k: fix AP/IBSS CSA with template based fw Michal Kazior
2015-02-12 13:53 ` Michal Kazior
2015-02-15 15:51 ` Kalle Valo
2015-02-15 15:51   ` Kalle Valo
2015-02-16  6:54   ` Michal Kazior
2015-02-16  6:54     ` Michal Kazior
2015-02-16 13:21     ` Kalle Valo [this message]
2015-02-16 13:21       ` Kalle Valo
2015-02-16 12:34 ` [PATCH v2] " Michal Kazior
2015-02-16 12:34   ` Michal Kazior
2015-03-07  7:46   ` Kalle Valo
2015-03-07  7:46     ` Kalle Valo
2015-03-09  9:30     ` Michal Kazior
2015-03-09  9:30       ` Michal Kazior
2015-03-09 12:25       ` Kalle Valo
2015-03-09 12:25         ` Kalle Valo
2015-03-09 13:19         ` [PATCH] ath10k: fix patching mistake for AP/IBSS CSA Michal Kazior
2015-03-09 13:19           ` Michal Kazior
2015-03-12 12:19           ` Kalle Valo
2015-03-12 12:19             ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877fvigff2.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.