From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56578)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1YLbxr-00011i-NH
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 13:24:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1YLbxo-0000GZ-6h
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 13:24:43 -0500
Received: from mx1.redhat.com ([209.132.183.28]:49508)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1YLbxn-0000GN-Tu
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 13:24:40 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <54DB8F37.2080101@redhat.com> (Eric Blake's message of "Wed, 11
	Feb 2015 10:19:51 -0700")
References: <1423673184-5903-1-git-send-email-dgilbert@redhat.com>
	<1423673184-5903-3-git-send-email-dgilbert@redhat.com>
	<54DB8F37.2080101@redhat.com>
Date: Wed, 11 Feb 2015 19:24:36 +0100
Message-ID: <877fvo8fx7.fsf@neno.neno>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v2 2/3] Add migrate_incoming
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: liang.z.li@intel.com, mjt@tls.msk.ru, "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>, qemu-devel@nongnu.org, amit.shah@redhat.com, pbonzini@redhat.com

Eric Blake <eblake@redhat.com> wrote:
> On 02/11/2015 09:46 AM, Dr. David Alan Gilbert (git) wrote:
>> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>> 
>> Add migrate_incoming/migrate-incoming to start an incoming
>> migration.
>> 
>> Once a qemu has been started with
>>     -incoming pause
>> 
>> the migration can be started by issuing:
>>     migrate_incoming uri
>> 
>> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>> ---
>>  hmp-commands.hx       | 16 ++++++++++++++++
>>  hmp.c                 | 14 ++++++++++++++
>>  hmp.h                 |  1 +
>>  migration/migration.c | 19 +++++++++++++++++++
>>  qapi-schema.json      | 15 +++++++++++++++
>>  qmp-commands.hx       | 31 ++++++++++++++++++++++++++++++-
>>  6 files changed, 95 insertions(+), 1 deletion(-)
>> 
>
>> +++ b/migration/migration.c
>> @@ -432,6 +432,25 @@ void migrate_del_blocker(Error *reason)
>>      migration_blockers = g_slist_remove(migration_blockers, reason);
>>  }
>>  
>> +void qmp_migrate_incoming(const char *uri, Error **errp)
>> +{
>> +    Error *local_err = NULL;
>> +
>> +    if (!paused_incoming) {
>> +        error_setg(errp, "-incoming pause is required for migrate_incoming");
>
> Might read easier as "'-incoming pause' is required...", but that's minor.
>
> Reviewed-by: Eric Blake <eblake@redhat.com>

As this is a very minor fix, I apply it by hand on my tree.

Thanks to all reviewers.

Applied, Juan.