From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKojE-0000Ke-Vn for qemu-devel@nongnu.org; Mon, 09 Feb 2015 08:50:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKojD-0000MA-O0 for qemu-devel@nongnu.org; Mon, 09 Feb 2015 08:50:20 -0500 From: Juan Quintela In-Reply-To: <54D8B58C.3020404@ilande.co.uk> (Mark Cave-Ayland's message of "Mon, 09 Feb 2015 13:26:36 +0000") References: <1423233416-25962-1-git-send-email-mark.cave-ayland@ilande.co.uk> <1423233416-25962-3-git-send-email-mark.cave-ayland@ilande.co.uk> <87mw4n1cp4.fsf@neno.neno> <54D8AB6B.1010901@suse.de> <54D8B58C.3020404@ilande.co.uk> Date: Mon, 09 Feb 2015 14:50:03 +0100 Message-ID: <877fvr19f8.fsf@neno.neno> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] openpic: convert to vmstate Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland Cc: amit.shah@redhat.com, qemu-ppc@nongnu.org, Alexander Graf , qemu-devel@nongnu.org Mark Cave-Ayland wrote: > On 09/02/15 12:43, Alexander Graf wrote: > Ha! I did actually do this but I accidentally messed up a rebase just > before sending out the patchset so it got lost. But yes, I agree a > version bump to 3 should be sufficient here. > > Just to put this in context: before the PPC loadvm/savevm patchset was > posted to the list, I was bisecting down to around the 0.10-0.11 > timeframe to figure out where things broke, and even then the Mac > machines wouldn't run correctly after loadvm. So I agree with Alex that > any snapshots this old would be useless anyway. > > Based upon this, are there any other changes you would like before a respin? I didn't knew that it was completely broken (TM). As said in a different email, I think that using the _EQUAL() macro for nb_cpus is a good idea. For the rest, I agree with it. Later, Juan.