From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45941)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1YDfPn-0007Xa-KZ
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 15:28:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1YDfPi-0005Je-Jv
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 15:28:43 -0500
Received: from mx1.redhat.com ([209.132.183.28]:58260)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1YDfPi-0005JY-BB
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 15:28:38 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <2ACCDD16-AFEC-49BF-8BD3-3A3EC55DB2E5@gmail.com>
	<87oapt7sxo.fsf@blackfin.pond.sub.org>
	<2AB4B322-B3CF-4609-B57E-32B93C124761@gmail.com>
	<54BE72CA.1030106@redhat.com>
	<317CCA7A-98DD-487A-8F80-3A96F8E3FC80@gmail.com>
Date: Tue, 20 Jan 2015 21:28:29 +0100
In-Reply-To: <317CCA7A-98DD-487A-8F80-3A96F8E3FC80@gmail.com>
	(Programmingkid's message of "Tue, 20 Jan 2015 11:08:20 -0500")
Message-ID: <877fwhryc2.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v8] block/raw-posix.c: Fix raw_getlength()
	on Mac OS X for CD
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Programmingkid <programmingkidx@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, qemu-devel qemu-devel <qemu-devel@nongnu.org>

Programmingkid <programmingkidx@gmail.com> writes:

> On Jan 20, 2015, at 10:22 AM, Eric Blake wrote:
>
>> On 01/20/2015 07:29 AM, Programmingkid wrote:
>>> 
>>> On Jan 20, 2015, at 3:33 AM, Markus Armbruster wrote:
>>> 
>>>> Programmingkid <programmingkidx@gmail.com> writes:
>>>> 
>>>>> Subject was: 
>>>>> Re: [PATCH v7] block/raw-posix.c: Fixes raw_getlength() 
>>>>> on Mac OS X so that it reports the correct length of a real CD
>>>> 
>>>> Patch history information goes...
>> 
>>>> 
>>>> ... below the --- divider.
>>> 
>>> I thought I did this. The information above is the description of the patch. 
>>> Not its history.
>> 
>> Anything that mentions 'v7' is history.  When you read 'git log', you
>> will not see mentions of 'v7', because no one cares how many tries it
>> took to get a patch into git.  Knowing about v7 only matters to the
>> reviewers of v8, hence it is patch history that belongs after the divider.
>
> Ok. 
>
>> 
>> 
>>>>> +
>>>>> +            if (ioctl(fd, DKIOCGETBLOCKCOUNT, &sectors) == 0
>>>>> +               && ioctl(fd, DKIOCGETBLOCKSIZE, &sector_size) == 0) {
>> 
>> Indentation looks off here.
>
> It does look a little odd, but it also communicates that this is one
> statement (IMHO).

It's not how the rest of QEMU is indented.  Please try to blend in :)

I feel bad about notpicking v8 of an obviously useful and patch that is
basically just fine except for these little things.  Thanks for
persevering!