All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lluís Vilanova" <vilanova@ac.upc.edu>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Cc: qemu-devel@nongnu.org, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH] tcg: Add doxygen documentation to the tcg frontend
Date: Wed, 14 Jan 2015 19:15:09 +0100	[thread overview]
Message-ID: <877fwpp6tu.fsf@fimbulvetr.bsc.es> (raw)
In-Reply-To: <54B6BAF7.4070006@mail.uni-paderborn.de> (Bastian Koppelmann's message of "Wed, 14 Jan 2015 18:52:39 +0000")

Bastian Koppelmann writes:

> On 01/14/2015 03:36 PM, Lluís Vilanova wrote:
>> Bastian Koppelmann writes:
>> 
>>> There is no overview, that shows all the frontend operation one can use, as
>>> found on the wiki. Unfortunatly the wiki is out of date, so let's try to move
>>> this documentation to the source files, which has the benefit, that it is easy
>>> to update the documentation, if the frontend is changed. This patch adds doxygen
>>> tags to all the 32 bit versions of the tcg frontend operations, because the
>>> 64 bit version would mostly have the same documentation, and all the type
>>> conversition operations. The file tag has a note, that makes the user aware of
>>> the missing 64 operations. In this version all the immediate variants are also
>>> documented by simply refering to the non immediate version. However I'm willing
>>> to drop that.
>>> Any comments?
>> The operations (or at least most of them) are already documented in
>> tcg/README. If this change is accepted, I'd rather move the contents of the
>> README file into here.
> The README file contains IIRC only operation, which are also represented by the
> intermediate format of tcg. Unfortunately this excludes useful helpers like
> subfi. So Richard suggested commenting the header file. However I wouldn't add
> only those helpers like subfi to the doxygen documentation, since the idea is to
> have a good overview. If you have another suggestion I'm happy to hear it :).

Sorry I wasn't clear. I meant that it might be better to remove tcg/README and
instead document all the operations (those in the readme and the additional
ones) in the header.


Thanks,
  Lluis

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth

  reply	other threads:[~2015-01-14 18:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14 15:51 [Qemu-devel] [PATCH] tcg: Add doxygen documentation to the tcg frontend Bastian Koppelmann
2015-01-14 15:36 ` Lluís Vilanova
2015-01-14 16:55   ` Thomas Huth
2015-01-14 18:55     ` Bastian Koppelmann
2015-01-14 18:52   ` Bastian Koppelmann
2015-01-14 18:15     ` Lluís Vilanova [this message]
2015-01-14 18:24       ` Peter Maydell
2015-01-14 18:36       ` Richard Henderson
2015-01-15 11:40         ` Lluís Vilanova
2015-01-14 19:03 ` Bastian Koppelmann
2015-01-21 18:12 ` Bastian Koppelmann
2015-01-21 19:44   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877fwpp6tu.fsf@fimbulvetr.bsc.es \
    --to=vilanova@ac.upc.edu \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.