From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54127)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Y1C6G-00010Y-Jd
	for qemu-devel@nongnu.org; Wed, 17 Dec 2014 05:45:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Y1C6A-00013n-ER
	for qemu-devel@nongnu.org; Wed, 17 Dec 2014 05:45:00 -0500
Received: from mx1.redhat.com ([209.132.183.28]:42448)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Y1C6A-00013e-75
	for qemu-devel@nongnu.org; Wed, 17 Dec 2014 05:44:54 -0500
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBHAirda001178
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 17 Dec 2014 05:44:53 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <1415156231-6319-1-git-send-email-famz@redhat.com>
Date: Wed, 17 Dec 2014 11:44:51 +0100
In-Reply-To: <1415156231-6319-1-git-send-email-famz@redhat.com> (Fam Zheng's
	message of "Wed, 5 Nov 2014 10:57:08 +0800")
Message-ID: <877fxqv9lo.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v3 0/3] qmp: Add "blockdev-backup"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, mreitz@redhat.com

Fam Zheng <famz@redhat.com> writes:

> v3: Address Eric's comments on documentation.
>     Squashed 3/4 into 2/4.
>
> v2: Address Markus' and Eric's comments:
>     Fix qapi schema documentation.
>     Fix versioning of transactions.
>     Improve test case code by dropping inelegnet bool.
>
> The existing drive-backup command accepts a target file path, but that
> interface provides little flexibility on the properties of target block device,
> compared to what is possible with "blockdev-add", "drive_add" or "-drive".
>
> This is also a building block to allow image fleecing (creating a point in time
> snapshot and export with nbd-server-add).
>
> (For symmetry, blockdev-mirror will be added in a separate series.)

Trivial typos/pastos in PATCH 1, and a question on GenericError.  If you
address these, you can add my R-by.