From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: Possible regression in 3.17-rc2 in i915 driver Date: Mon, 01 Sep 2014 09:25:42 +0300 Message-ID: <877g1ndfh5.fsf@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id E156D6E211 for ; Sun, 31 Aug 2014 23:25:59 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tibor Billes , Ville =?utf-8?B?U3lyasOkbMOk?= , David Airlie , Daniel Vetter Cc: "intel-gfx@lists.freedesktop.org" , linux-kernel@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org CitpbnRlbC1nZngKClZpbGxlLCBEYW5pZWwsIGFueSB0aG91Z2h0cyBiZWZvcmUgd2UgcXVldWUg YSByZXZlcnQ/CgpCUiwKSmFuaS4KCgpPbiBTdW4sIDMxIEF1ZyAyMDE0LCBUaWJvciBCaWxsZXMg PHRiaWxsZXNAZ214LmNvbT4gd3JvdGU6Cj4gSGkhCj4KPiBJIHRyaWVkIHRvIHVwZ3JhZGUgbXkg a2VybmVsIGZyb20gMy4xNiB0byAzLjE3LXJjMiBhbmQgSSBmb3VuZCB0aGF0IG15IGxhcHRvcAo+ IHdhcyB1bmFibGUgdG8gYm9vdC4gVGhlIGJvb3QgcHJvY2VzcyBoYW5ncyBhZnRlciAyLTMgc2Vj b25kcyAoYWNjb3JkaW5nIHRvCj4gdGltZXN0YW1wcyBvZiBsb2cgbWVzc2FnZXMpLiBUaGUgbGFz dCBrZXJuZWwgbG9nIGxpbmUgSSB1c3VhbGx5IHNlZSBpcyB0aGUKPiBkaXNjb3Zlcnkgb2YgbXkg dG91Y2hwYWQ6ICJpbnB1dDogU3luUFMvMiBTeW5hcHRpY3MgVG91Y2hQYWQgYXMKPiAvZGV2aWNl cy9wbGF0Zm9ybS9pODA0Mi9zZXJpbzIvaW5wdXQvaW5wdXQxMSIuCj4KPiBJIGRpZCBhIGdpdCBi aXNlY3QgYW5kIGl0IHBvaW50ZWQgbWUgdG8gdGhlIGZvbGxvd2luZyBjb21taXQ6Cj4gY29tbWl0 IDIwOGJmOWZkY2QzNTc1YWE0YTVkNDhiM2UwMjk1ZjdjZGFmNmZjNDQKPiBBdXRob3I6IFZpbGxl IFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gRGF0ZTrCoMKgIE1v biBBdWcgMTEgMTM6MTU6MzUgMjAxNCArMDMwMAo+IMKgCj4gwqDCoMKgIGRybS9pOTE1OiBGaXgg bG9ja2luZyBmb3IgaW50ZWxfZW5hYmxlX3BpcGVfYSgpCj4gwqAKPiDCoMKgwqAgaW50ZWxfZW5h YmxlX3BpcGVfYSgpIGdldHMgY2FsbGVkIHdpdGggYWxsIHRoZSBtb2Rlc2V0IGxvY2tzIGFscmVh ZHkKPiDCoMKgwqAgaGVsZCAoYnkgZHJtX21vZGVzZXRfbG9ja19hbGwoKSksIHNvIHRyeWluZyB0 byBncmFiIHRoZSBzYW1lCj4gwqDCoMKgIGxvY2tzIHVzaW5nIGFub3RoZXIgZHJtX21vZGVzZXRf YWNxdWlyZV9jdHggaXMgZ29pbmcgdG8gZmFpbCBtaXNlcmFibHkuCj4gwqDCoMKgIMKgCj4gwqDC oMKgIE1vdmUgbW9zdCBvZiB0aGUgZHJtX21vZGVzZXRfYWNxdWlyZV9jdHggaGFuZGxpbmcgKGlu aXQvZHJvcC9maW5pKQo+IMKgwqDCoCBvdXQgZnJvbSBpbnRlbF97Z2V0LHJlbGVhc2V9X2xvYWRf ZGV0ZWN0X3BpcGUoKSBpbnRvIHRoZSBjYWxsZXJzCj4gwqDCoMKgIChpbnRlbF97Y3J0LHR2fV9k ZXRlY3QoKSkuIE9ubHkgdGhlIGFjdHVhbCBsb2NraW5nIGFuZCBiYWNrb2ZmCj4gwqDCoMKgIGhh bmRsaW5nIGlzIGxlZnQgaW4gaW50ZWxfZ2V0X2xvYWRfZGV0ZWN0X3BpcGUoKS4gQW5kIGluCj4g wqDCoMKgIGludGVsX2VuYWJsZV9waXBlX2EoKSB3ZSBqdXN0IHNoYXJlIHRoZSBtb2RlX2NvbmZp Zy5hY3F1aXJlX2N0eCBmcm9tCj4gwqDCoMKgIGRybV9tb2Rlc2V0X2xvY2tfYWxsKCkgd2hpY2gg aXMgYWxyZWFkeSBob2xkaW5nIGFsbCB0aGUgcmVsZXZhbnQgbG9ja3MuCj4gwqDCoMKgIMKgCj4g wqDCoMKgIEl0J3MgcGVyZmVjdGx5IGxlZ2FsIHRvIGxvY2sgdGhlIHNhbWUgd3dfbXV0ZXggbXVs dGlwbGUgdGltZXMgdXNpbmcgdGhlCj4gwqDCoMKgIHNhbWUgd3dfYWNxdWlyZV9jdHguIGRybV9t b2Rlc2V0X2xvY2soKSB3aWxsIGNvbnZlcnQgdGhlIHJldHVybmVkCj4gwqDCoMKgIC1FQUxSRUFE WSBpbnRvIDAsIHNvIHRoZSBjYWxsZXIgZG9lc24ndCBuZWVkIHRvIGRvIGFudHloaW5nIHNwZWNp YWwuCj4gwqDCoMKgIMKgCj4gwqDCoMKgIEZpeGVzIGEgaGFuZyBvbiByZXN1bWUgb24gbXkgODMw Lgo+IMKgwqDCoCDCoAo+IMKgwqDCoCBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZp bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IMKgwqDCoCBSZXZpZXdlZC1ieTogRGFuaWVs IFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiDCoMKgwqAgQ2M6IHN0YWJsZUB2Z2Vy Lmtlcm5lbC5vcmcKPiDCoMKgwqAgU2lnbmVkLW9mZi1ieTogSmFuaSBOaWt1bGEgPGphbmkubmlr dWxhQGludGVsLmNvbT4KPiDCoAo+IEkgdHJpZWQgYm9vdGluZyB3aXRoIHRoZSBhYm92ZSBjb21t aXQgcmV2ZXJ0ZWQgb24gdG9wIG9mIDMuMTctcmMyIGFuZCBpdAo+IGJvb3RlZCBzdWNjZXNzZnVs bHkuCj4gwqAKPiBJIGFsc28gZGlkIGEgTWFnaWNTeXJxLVcgKERpc3BsYXkgbGlzdCBvZiBibG9j a2VkIChEIHN0YXRlKSB0YXNrcykgYWZ0ZXIgdGhlCj4gYm9vdCBwcm9jZXNzIHN0b3BwZWQgKHVz aW5nIHBsYWluIDMuMTctcmMyLCB3aXRob3V0IHJldmVydGluZyB0aGUgYWJvdmUgY29tbWl0KQo+ IGFuZCBpdCBzaG93ZWQgdGhhdCBwbHltb3V0aGQgd2FzIGJsb2NrZWQgd2l0aCB0aGUgZm9sbG93 aW5nIGNhbGwgdHJhY2UgKGhhbmQKPiBjb3BpZWQpOgo+IGlycV9leGl0Cj4gY29tbW9uX2ludGVy cnVwdAo+IHNjaGVkdWxlX3ByZWVtdF9kaXNhYmxlZAo+IF9fbXV0ZXhfbG9ja19zbG93cGF0aAo+ IG11dGV4X2xvY2sKPiBkcm1fbW9kZXNldF9sb2NrCj4gZHJtX2dldGNvbm5lY3Rvcgo+IGRybV9t b2RlX2dldGNydHRjCj4gZHJtX2lvY3RsCj4gLi4uCj4gwqAKPiBUaGlzIG1heSBoYXZlIHNvbWV0 aGluZyB0byBkbyB3aXRoIHRoZSBoYW5nIG9yIGl0IG1heSBub3QsIEkgZG9uJ3Qga25vdyBidXQg aXMKPiByZWxhdGVkIHRvIGRybSBsb2NraW5nIHNvIEkgdGhvdWdodCBpdCB3YXMgYSBnb29kIGlk ZWEgdG8gbWVudGlvbiBpdC4KPiDCoAo+IE15IGxhcHRvcCBpcyBhbiBvbGQgRnVqaXRzdS1TaWVt ZW5zIEFtaWxvIE0xNDUwZywgcnVubmluZyBMaW51eCBNaW50IDE2Lgo+IMKgCj4gTGV0IG1lIGtu b3cgaWYgSSBjYW4gaGVscCBmdXJ0aGVyIGRlYnVnIHRoaXMgaXNzdWUuCj4gwqAKPiBUaWJvciBC aWxsZXMKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50 ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752311AbaIAG0B (ORCPT ); Mon, 1 Sep 2014 02:26:01 -0400 Received: from mga01.intel.com ([192.55.52.88]:54634 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751948AbaIAGZ7 convert rfc822-to-8bit (ORCPT ); Mon, 1 Sep 2014 02:25:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,440,1406617200"; d="scan'208";a="584426949" From: Jani Nikula To: Tibor Billes , Ville =?utf-8?B?U3lyasOkbMOk?= , David Airlie , Daniel Vetter Cc: linux-kernel@vger.kernel.org, "intel-gfx\@lists.freedesktop.org" Subject: Re: Possible regression in 3.17-rc2 in i915 driver In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: User-Agent: Notmuch/0.18.1+66~g7487985 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Mon, 01 Sep 2014 09:25:42 +0300 Message-ID: <877g1ndfh5.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +intel-gfx Ville, Daniel, any thoughts before we queue a revert? BR, Jani. On Sun, 31 Aug 2014, Tibor Billes wrote: > Hi! > > I tried to upgrade my kernel from 3.16 to 3.17-rc2 and I found that my laptop > was unable to boot. The boot process hangs after 2-3 seconds (according to > timestamps of log messages). The last kernel log line I usually see is the > discovery of my touchpad: "input: SynPS/2 Synaptics TouchPad as > /devices/platform/i8042/serio2/input/input11". > > I did a git bisect and it pointed me to the following commit: > commit 208bf9fdcd3575aa4a5d48b3e0295f7cdaf6fc44 > Author: Ville Syrjälä > Date:   Mon Aug 11 13:15:35 2014 +0300 >   >     drm/i915: Fix locking for intel_enable_pipe_a() >   >     intel_enable_pipe_a() gets called with all the modeset locks already >     held (by drm_modeset_lock_all()), so trying to grab the same >     locks using another drm_modeset_acquire_ctx is going to fail miserably. >       >     Move most of the drm_modeset_acquire_ctx handling (init/drop/fini) >     out from intel_{get,release}_load_detect_pipe() into the callers >     (intel_{crt,tv}_detect()). Only the actual locking and backoff >     handling is left in intel_get_load_detect_pipe(). And in >     intel_enable_pipe_a() we just share the mode_config.acquire_ctx from >     drm_modeset_lock_all() which is already holding all the relevant locks. >       >     It's perfectly legal to lock the same ww_mutex multiple times using the >     same ww_acquire_ctx. drm_modeset_lock() will convert the returned >     -EALREADY into 0, so the caller doesn't need to do antyhing special. >       >     Fixes a hang on resume on my 830. >       >     Signed-off-by: Ville Syrjälä >     Reviewed-by: Daniel Vetter >     Cc: stable@vger.kernel.org >     Signed-off-by: Jani Nikula >   > I tried booting with the above commit reverted on top of 3.17-rc2 and it > booted successfully. >   > I also did a MagicSyrq-W (Display list of blocked (D state) tasks) after the > boot process stopped (using plain 3.17-rc2, without reverting the above commit) > and it showed that plymouthd was blocked with the following call trace (hand > copied): > irq_exit > common_interrupt > schedule_preemt_disabled > __mutex_lock_slowpath > mutex_lock > drm_modeset_lock > drm_getconnector > drm_mode_getcrttc > drm_ioctl > ... >   > This may have something to do with the hang or it may not, I don't know but is > related to drm locking so I thought it was a good idea to mention it. >   > My laptop is an old Fujitsu-Siemens Amilo M1450g, running Linux Mint 16. >   > Let me know if I can help further debug this issue. >   > Tibor Billes -- Jani Nikula, Intel Open Source Technology Center