Re: [PATCH 2/2] perf tools: Default to python version 2

[Namhyung Kim <namhyung@gmail.com>]

Hi Thomas,

On Mon, 28 Jul 2014 13:11:05 +0200, Thomas Ilsche wrote:
> Hi Namhyung,
>
>>>> I'm thinking about something like below.. but sadly it doesn't work for
>>>> me.. hmm.
>>>
>>> Actually this appears to work for me (with 2.6.9 & 2.7.6) and I  
>>> find this solution more
>>> elegant.
>>
>> Thanks for testing.  It was my fault on setting symlink to a
>> non-existing file for testing.  It now works well for me too.
>>
>> Can I add your Tested-by then?
>
> Yes
> Tested-by: Thomas Ilsche <thomas.ilsche@tu-dresden.de>
>
> Plase note that your patch requires the previous patch that just set
> the default to python2.

Ah, I'll fix it when sending v2.


>
> I tested in an Arch Linux VM with:
> A) no system install of python, source installation 2.6.9 in PATH
> B) no system install of python, source installation 2.7.6 in PATH
> C) python3 (as python) and python2 system installation
>
> In all cases it reports to build with libpython and perf script with a dummy Python script
> works.
>
> If no python whatsoever is in PATH it reports:
>
> config/Makefile:121: The path 'python' is not executable.
> sh: line 0: command: -c: invalid option
> command: usage: command [-pVv] command [arg ...]
> config/Makefile:122: The path '-config' is not executable.
>
> And the created perf executable does not work with the dummy script.
>
> If only pthon3 is in PATH I get the expected version error message (build stops.)
>
> Note that for the manual old installations of python I had an issue with linking order and
> a -Werror issue that I resolved manually. But this is fixed with the latest system install
> of python.

Thank you a lot for testing and explaining various cases!

Namhyung