All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@gmail.com>
To: Stanislav Fomichev <stfomichev@yandex-team.ru>
Cc: acme@kernel.org, artagnon@gmail.com, jolsa@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] perf timechart: implement IO mode
Date: Tue, 10 Jun 2014 16:28:37 +0900	[thread overview]
Message-ID: <877g4pb4uy.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <1402305672-2630-3-git-send-email-stfomichev@yandex-team.ru> (Stanislav Fomichev's message of "Mon, 9 Jun 2014 13:21:12 +0400")

On Mon,  9 Jun 2014 13:21:12 +0400, Stanislav Fomichev wrote:
> In IO mode timechart shows any disk/network activity.

It breaks build like below:

    CC       util/svghelper.o
  util/svghelper.c: In function ‘svg_ubox’:
  util/svghelper.c:154:91: error: declaration of ‘error’ shadows a global declaration [-Werror=shadow]
  In file included from util/svghelper.c:24:0:
  util/util.h:137:12: error: shadowed declaration is here [-Werror=shadow]
  util/svghelper.c: In function ‘svg_lbox’:
  util/svghelper.c:173:91: error: declaration of ‘error’ shadows a global declaration [-Werror=shadow]
  In file included from util/svghelper.c:24:0:
  util/util.h:137:12: error: shadowed declaration is here [-Werror=shadow]
  util/svghelper.c: In function ‘svg_fbox’:
  util/svghelper.c:192:91: error: declaration of ‘error’ shadows a global declaration [-Werror=shadow]
  In file included from util/svghelper.c:24:0:
  util/util.h:137:12: error: shadowed declaration is here [-Werror=shadow]
  cc1: all warnings being treated as errors
  make[1]: *** [util/svghelper.o] Error 1


Thanks,
Namhyung

  parent reply	other threads:[~2014-06-10  7:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-09  9:21 [PATCH 0/2] perf timechart fix & io mode Stanislav Fomichev
2014-06-09  9:21 ` [PATCH 1/2] perf timechart: fix documentation Stanislav Fomichev
2014-06-10  7:14   ` Namhyung Kim
2014-06-10  9:52     ` [PATCH 1/2 v2] " Stanislav Fomichev
2014-06-12 12:04       ` [tip:perf/core] perf timechart: Reflow documentation tip-bot for Stanislav Fomichev
2014-06-09  9:21 ` [PATCH 2/2] perf timechart: implement IO mode Stanislav Fomichev
2014-06-09 19:25   ` Arnaldo Carvalho de Melo
2014-06-10  7:28   ` Namhyung Kim [this message]
2014-06-10  7:50   ` Namhyung Kim
2014-06-10  9:08     ` Stanislav Fomichev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877g4pb4uy.fsf@sejong.aot.lge.com \
    --to=namhyung@gmail.com \
    --cc=acme@kernel.org \
    --cc=artagnon@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stfomichev@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.