From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39641)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1WhQEv-0007mU-Pi
	for qemu-devel@nongnu.org; Mon, 05 May 2014 17:16:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1WhQEp-0008Sf-Gt
	for qemu-devel@nongnu.org; Mon, 05 May 2014 17:15:57 -0400
Received: from roura.ac.upc.es ([147.83.33.10]:46291)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1WhQEo-0008SA-Ok
	for qemu-devel@nongnu.org; Mon, 05 May 2014 17:15:51 -0400
From: =?utf-8?Q?Llu=C3=ADs_Vilanova?= <vilanova@ac.upc.edu>
References: <20140502135218.31383.90270.stgit@fimbulvetr.bsc.es>
	<20140502135241.31383.48774.stgit@fimbulvetr.bsc.es>
	<20140505163101.48628872@redhat.com>
Date: Mon, 05 May 2014 23:15:45 +0200
In-Reply-To: <20140505163101.48628872@redhat.com> (Luiz Capitulino's message
	of "Mon, 5 May 2014 16:31:01 -0400")
Message-ID: <877g609bb2.fsf@fimbulvetr.bsc.es>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v12 4/4] qapi: Add a primitive to include
	other files from a QAPI schema file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: =?utf-8?Q?Beno=C3=AEt?= Canet <benoit.canet@irqsave.net>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

Luiz Capitulino writes:

> On Fri,  2 May 2014 15:52:41 +0200
> Llu=C3=ADs Vilanova <vilanova@ac.upc.edu> wrote:

>> --- a/scripts/qapi.py
>> +++ b/scripts/qapi.py
>> @@ -11,6 +11,8 @@
>> # This work is licensed under the terms of the GNU GPL, version 2.
>> # See the COPYING file in the top-level directory.
>>=20
>> +import os
>> +import re
>> from ordereddict import OrderedDict
>> import os
>> import sys
>> @@ -36,9 +38,17 @@ builtin_type_qtypes =3D {
>> 'uint64':   'QTYPE_QINT',
>> }

> You're importing os twice in this series. I saw this while applying an
> unrelated patch on top. I'll drop the import added by this patch, please
> reply ACKing or NACKing.

Ok.

Sorry for the silly mistake.

Lluis

--=20
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth