From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLKfg-000711-89 for qemu-devel@nongnu.org; Wed, 05 Mar 2014 17:52:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLKfX-0007tY-Bd for qemu-devel@nongnu.org; Wed, 05 Mar 2014 17:52:16 -0500 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:38782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLKfW-0007sT-Kl for qemu-devel@nongnu.org; Wed, 05 Mar 2014 17:52:07 -0500 Received: from /spool/local by e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 6 Mar 2014 08:52:02 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id D04C12CE803F for ; Thu, 6 Mar 2014 09:51:58 +1100 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s25MW3Rx58589236 for ; Thu, 6 Mar 2014 09:32:04 +1100 Received: from d23av02.au.ibm.com (localhost [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s25MpvEV022959 for ; Thu, 6 Mar 2014 09:51:57 +1100 From: Stewart Smith In-Reply-To: <1394008356-15320-1-git-send-email-bharata@linux.vnet.ibm.com> References: <1394008356-15320-1-git-send-email-bharata@linux.vnet.ibm.com> Date: Thu, 06 Mar 2014 09:51:57 +1100 Message-ID: <877g88jm2a.fsf@river.au.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2] ppc: Force CPU threads count to be a power of 2. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao , qemu-devel@nongnu.org Cc: aik@ozlabs.ru, agraf@suse.de Bharata B Rao writes: > PowerPC kernel expects the number of SMT threads in a core to be a power > of 2. Since QEMU doesn't enforce this, it leads to an early guest kernel > crash if invalid threads count is specified. > > Prevent this crash and make it a graceful exit from QEMU itself by > validating the user supplied threads count. > > Signed-off-by: Bharata B Rao Reviewed-by: Stewart Smith