From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34407)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1VsU6R-0003gU-TN
	for qemu-devel@nongnu.org; Mon, 16 Dec 2013 04:04:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1VsU6M-0002UA-IC
	for qemu-devel@nongnu.org; Mon, 16 Dec 2013 04:04:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:3835)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1VsU6M-0002U3-9W
	for qemu-devel@nongnu.org; Mon, 16 Dec 2013 04:04:34 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <1384307094-5836-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1384307094-5836-3-git-send-email-xiawenc@linux.vnet.ibm.com>
	<52AB0C17.8020704@redhat.com>
	<20131213134331.GI3916@dhcp-200-207.str.redhat.com>
	<52AE6A5E.40907@linux.vnet.ibm.com>
Date: Mon, 16 Dec 2013 10:04:28 +0100
In-Reply-To: <52AE6A5E.40907@linux.vnet.ibm.com> (Wenchao Xia's message of
	"Mon, 16 Dec 2013 10:50:06 +0800")
Message-ID: <877gb5majn.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH RFC 2/3] qapi script: add support of event
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, pbonzini@redhat.com, lcapitulino@redhat.com

Wenchao Xia <xiawenc@linux.vnet.ibm.com> writes:

> =E4=BA=8E 2013/12/13 21:43, Kevin Wolf =E5=86=99=E9=81=93:
>> Am 13.12.2013 um 14:31 hat Eric Blake geschrieben:
>>> On 11/12/2013 06:44 PM, Wenchao Xia wrote:
>>>> +++ b/scripts/qapi-event.py
>>>> @@ -0,0 +1,355 @@
>>>> +#
>>>> +# QAPI event generator
>>>> +#
>>>> +# Copyright IBM, Corp. 2013
>>>> +#
>>>> +# Authors:
>>>> +#  Wenchao Xia <xiawenc@linux.vnet.ibm.com>
>>>> +#
>>>> +# This work is licensed under the terms of the GNU GPLv2.
>>>
>>> Can you please use GPLv2+ (that is, add the "or later" clause)?  We
>>> already have GPLv2-only code, but I don't want to increase the size of
>>> that unfortunate license choice.
>>
>> In fact, it's even worse:
>>
>> +# This work is licensed under the terms of the GNU GPLv2.
>> +# See the COPYING.LIB file in the top-level directory.
>>
>> These two lines contradict each other, COPYING.LIB contains the
>> LGPL 2.1. The same bad license header is in the other QAPI generator
>> scripts, so it's only copy&paste here.
>>
>> This doesn't make things easier, because if things are copied, the
>> license of the source must be respected. And it seems rather dubious to
>> me what this license actually is. If it's GPLv2-only, we can't just
>> change it in the new copy.
>>
>> Kevin
>>
>   ah..I am bad in license problem, will use the doc as LGPL from other
> file.

Please use GPLv2+ unless you have a specific reason for another license.