From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth01.qualcomm.com ([65.197.215.72]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1V5A5t-0000Tv-4s for ath10k@lists.infradead.org; Fri, 02 Aug 2013 07:48:13 +0000 From: Kalle Valo Subject: Re: [PATCH] ath10k: add SoC power save option to PCI features map References: <1375348187-18216-1-git-send-email-bartosz.markowski@tieto.com> Date: Fri, 2 Aug 2013 10:47:44 +0300 In-Reply-To: <1375348187-18216-1-git-send-email-bartosz.markowski@tieto.com> (Bartosz Markowski's message of "Thu, 1 Aug 2013 11:09:47 +0200") Message-ID: <877gg4pm8v.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Bartosz Markowski Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Bartosz Markowski writes: > Unify the PCI options location. > > By default the SoC PS option is disabled to boost the > performance and due to poor stability on early HW revisions. > In future we can remove the module parameter and turn on/off > the PS for given hardware. > > This change also makes the pci module parameter for SoC PS static. > > Signed-off-by: Bartosz Markowski A minor nitpick: > + if (!test_bit(ATH10K_PCI_FEATURE_SOC_POWER_SAVE, ar_pci->features)) > + ath10k_do_pci_wake(ar); /* Force AWAKE forever */ if (foo) /* comment */ function_call(); -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth02.qualcomm.com ([65.197.215.38]:58728 "EHLO sabertooth02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932090Ab3HBHrv (ORCPT ); Fri, 2 Aug 2013 03:47:51 -0400 From: Kalle Valo To: Bartosz Markowski CC: , Subject: Re: [PATCH] ath10k: add SoC power save option to PCI features map References: <1375348187-18216-1-git-send-email-bartosz.markowski@tieto.com> Date: Fri, 2 Aug 2013 10:47:44 +0300 In-Reply-To: <1375348187-18216-1-git-send-email-bartosz.markowski@tieto.com> (Bartosz Markowski's message of "Thu, 1 Aug 2013 11:09:47 +0200") Message-ID: <877gg4pm8v.fsf@kamboji.qca.qualcomm.com> (sfid-20130802_094756_278215_1E4096EF) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Bartosz Markowski writes: > Unify the PCI options location. > > By default the SoC PS option is disabled to boost the > performance and due to poor stability on early HW revisions. > In future we can remove the module parameter and turn on/off > the PS for given hardware. > > This change also makes the pci module parameter for SoC PS static. > > Signed-off-by: Bartosz Markowski A minor nitpick: > + if (!test_bit(ATH10K_PCI_FEATURE_SOC_POWER_SAVE, ar_pci->features)) > + ath10k_do_pci_wake(ar); /* Force AWAKE forever */ if (foo) /* comment */ function_call(); -- Kalle Valo