From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 01/10] drm/i915: kill ivybridge_irq_preinstall Date: Fri, 19 Jul 2013 15:02:41 +0300 Message-ID: <877ggmahb2.fsf@gaia.fi.intel.com> References: <1373657718-3008-1-git-send-email-przanoni@gmail.com> <1373657718-3008-2-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id EF762E5F72 for ; Fri, 19 Jul 2013 05:02:47 -0700 (PDT) In-Reply-To: <1373657718-3008-2-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni , intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org Paulo Zanoni writes: > From: Paulo Zanoni > > After Daniel's latest changes it's now equal to > ironlake_irq_preinstall. > > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/i915_irq.c | 21 +-------------------- > 1 file changed, 1 insertion(+), 20 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index ca9df54..f397f9a 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -2090,25 +2090,6 @@ static void ironlake_irq_preinstall(struct drm_device *dev) > ibx_irq_preinstall(dev); > } > > -static void ivybridge_irq_preinstall(struct drm_device *dev) > -{ > - drm_i915_private_t *dev_priv = (drm_i915_private_t *) dev->dev_private; > - > - atomic_set(&dev_priv->irq_received, 0); > - > - I915_WRITE(HWSTAM, 0xeffe); > - > - /* XXX hotplug from PCH */ This comment will be lost. I couldn't figure out if it is is relevant anymore or not. Reviewed-by: Mika Kuoppala > - I915_WRITE(DEIMR, 0xffffffff); > - I915_WRITE(DEIER, 0x0); > - POSTING_READ(DEIER); > - > - gen5_gt_irq_preinstall(dev); > - > - ibx_irq_preinstall(dev); > -} > - > static void valleyview_irq_preinstall(struct drm_device *dev) > { > drm_i915_private_t *dev_priv = (drm_i915_private_t *) dev->dev_private; > @@ -3116,7 +3097,7 @@ void intel_irq_init(struct drm_device *dev) > } else if (IS_IVYBRIDGE(dev) || IS_HASWELL(dev)) { > /* Share uninstall handlers with ILK/SNB */ > dev->driver->irq_handler = ivybridge_irq_handler; > - dev->driver->irq_preinstall = ivybridge_irq_preinstall; > + dev->driver->irq_preinstall = ironlake_irq_preinstall; > dev->driver->irq_postinstall = ivybridge_irq_postinstall; > dev->driver->irq_uninstall = ironlake_irq_uninstall; > dev->driver->enable_vblank = ivybridge_enable_vblank; > -- > 1.8.1.2 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx