From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it. Date: Thu, 23 May 2013 22:59:55 -0700 Message-ID: <877gio3okk.fsf@xmission.com> References: <519DCBEF.3090208@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <519DCBEF.3090208@asianux.com> (Chen Gang's message of "Thu, 23 May 2013 15:57:35 +0800") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org Cc: Catalin Marinas , linux-sh@vger.kernel.org, Benjamin Herrenschmidt , heiko.carstens@de.ibm.com, "paulus@samba.org" , hpa@zytor.com, walken@google.com, egtvedt@samfundet.no, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Russell King - ARM Linux , user-mode-linux-devel@lists.sourceforge.net, ysato@users.sourceforge.jp, richard@nod.at, deller@gmx.de, x86@kernel.org, jejb@parisc-linux.org, "mingo@redhat.com" , Geert Uytterhoeven , Frederic Weisbecker , paulmck@linux.vnet.ibm.com, hskinnemoen@gmail.com, Serge Hallyn , Mike Frysinger , Arnd Bergmann , Will Deacon , jdike@addtoit.com, akinobu.mita@gmail.com, user-mode-linux-user@lists.s List-Id: linux-arch.vger.kernel.org Chen Gang writes: > The crazy user can unset 'CONFIG_BUG' in menuconfig: "> General setup > > Configure standard kernel features (expert users) > BUG() Support". > > But in fact, we always need it, and quite a few of architectures have > already implemented it (e.g. alpha, arc, arm, avr32, blackfin, cris, > frv, ia64, m68k, mips, mn10300, parisc, powerpc, s390, sh, sparc, x86). > > And kernel also already has prepared a default effective implementation > for the architectures which is unwilling to implement it by themselves > (e.g. arm64, c6x, h8300, hexagon, m32r, metag, microblaze, openrisc, > score, tile, um, unicore32, xtensa). > > So need get rid of 'CONFIG_BUG', and let it always enabled everywhere. This looks like the right way to handle this to me. If the BUG annotations are too big and not needed they should simply be deleted from the code base. Disabling CONFIG_BUG which removes the BUG annotations from the binaries without modifying the source code seems like the wrong approach. Acked-by: "Eric W. Biederman" From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: ebiederm@xmission.com (Eric W. Biederman) References: <519DCBEF.3090208@asianux.com> Date: Thu, 23 May 2013 22:59:55 -0700 In-Reply-To: <519DCBEF.3090208@asianux.com> (Chen Gang's message of "Thu, 23 May 2013 15:57:35 +0800") Message-ID: <877gio3okk.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it. Cc: Russell King - ARM Linux , hskinnemoen@gmail.com, egtvedt@samfundet.no, Mike Frysinger , ysato@users.sourceforge.jp, rkuo@codeaurora.org, jejb@parisc-linux.org, deller@gmx.de, Benjamin Herrenschmidt , "paulus@samba.org" , schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, linux390@de.ibm.com, lethal@linux-sh.org, jdike@addtoit.com, richard@nod.at, Thomas Gleixner , "mingo@redhat.com" , hpa@zytor.com, x86@kernel.org, Arnd Bergmann , Serge Hallyn , paulmck@linux.vnet.ibm.com, Frederic Weisbecker , David Miller , Andrew Morton , akinobu.mita@gmail.com, Catalin Marinas , walken@google.com, Will Deacon , Geert Uytterhoeven , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , uclinux-dist-devel@blackfin.uclinux.org, linux-hexagon@vger.kernel.org, linux-parisc@vger.kernel.org, "linuxppc-dev@lists.ozlabs.org" , linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net, user-mode-linux-user@lists.sourceforge.net, linux-arch@vger.kernel.org List-ID: Chen Gang writes: > The crazy user can unset 'CONFIG_BUG' in menuconfig: "> General setup > > Configure standard kernel features (expert users) > BUG() Support". > > But in fact, we always need it, and quite a few of architectures have > already implemented it (e.g. alpha, arc, arm, avr32, blackfin, cris, > frv, ia64, m68k, mips, mn10300, parisc, powerpc, s390, sh, sparc, x86). > > And kernel also already has prepared a default effective implementation > for the architectures which is unwilling to implement it by themselves > (e.g. arm64, c6x, h8300, hexagon, m32r, metag, microblaze, openrisc, > score, tile, um, unicore32, xtensa). > > So need get rid of 'CONFIG_BUG', and let it always enabled everywhere. This looks like the right way to handle this to me. If the BUG annotations are too big and not needed they should simply be deleted from the code base. Disabling CONFIG_BUG which removes the BUG annotations from the binaries without modifying the source code seems like the wrong approach. Acked-by: "Eric W. Biederman" From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from etrn.xmission.com (etrn.xmission.com [198.60.22.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 90BD42C0174 for ; Fri, 24 May 2013 16:40:13 +1000 (EST) From: ebiederm@xmission.com (Eric W. Biederman) References: <519DCBEF.3090208@asianux.com> Date: Thu, 23 May 2013 22:59:55 -0700 In-Reply-To: <519DCBEF.3090208@asianux.com> (Chen Gang's message of "Thu, 23 May 2013 15:57:35 +0800") Message-ID: <877gio3okk.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it. Cc: Catalin Marinas , linux-sh@vger.kernel.org, heiko.carstens@de.ibm.com, "paulus@samba.org" , hpa@zytor.com, walken@google.com, egtvedt@samfundet.no, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Russell King - ARM Linux , user-mode-linux-devel@lists.sourceforge.net, ysato@users.sourceforge.jp, richard@nod.at, deller@gmx.de, x86@kernel.org, jejb@parisc-linux.org, "mingo@redhat.com" , Geert Uytterhoeven , Frederic Weisbecker , paulmck@linux.vnet.ibm.com, hskinnemoen@gmail.com, Serge Hallyn , Mike Frysinger , Arnd Bergmann , Will Deacon , jdike@addtoit.com, akinobu.mita@gmail.com, user-mode-linux-user@lists.sourceforge.net, uclinux-dist-devel@blackfin.uclinux.org, Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , linux-parisc@vger.kernel.org, "linux-kernel@vger.kernel.org" , rkuo@codeaurora.org, lethal@linux-sh.org, linux-hexagon@vger.kernel.org, schwidefsky@de.ibm.com, linux390@de.ibm.com, Andrew Morton , "linuxppc-dev@lists.ozlabs.org" , David Miller List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Chen Gang writes: > The crazy user can unset 'CONFIG_BUG' in menuconfig: "> General setup > > Configure standard kernel features (expert users) > BUG() Support". > > But in fact, we always need it, and quite a few of architectures have > already implemented it (e.g. alpha, arc, arm, avr32, blackfin, cris, > frv, ia64, m68k, mips, mn10300, parisc, powerpc, s390, sh, sparc, x86). > > And kernel also already has prepared a default effective implementation > for the architectures which is unwilling to implement it by themselves > (e.g. arm64, c6x, h8300, hexagon, m32r, metag, microblaze, openrisc, > score, tile, um, unicore32, xtensa). > > So need get rid of 'CONFIG_BUG', and let it always enabled everywhere. This looks like the right way to handle this to me. If the BUG annotations are too big and not needed they should simply be deleted from the code base. Disabling CONFIG_BUG which removes the BUG annotations from the binaries without modifying the source code seems like the wrong approach. Acked-by: "Eric W. Biederman" From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Date: Thu, 23 May 2013 22:59:55 -0700 Subject: [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it. In-Reply-To: <519DCBEF.3090208@asianux.com> (Chen Gang's message of "Thu, 23 May 2013 15:57:35 +0800") References: <519DCBEF.3090208@asianux.com> Message-ID: <877gio3okk.fsf@xmission.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Chen Gang writes: > The crazy user can unset 'CONFIG_BUG' in menuconfig: "> General setup > > Configure standard kernel features (expert users) > BUG() Support". > > But in fact, we always need it, and quite a few of architectures have > already implemented it (e.g. alpha, arc, arm, avr32, blackfin, cris, > frv, ia64, m68k, mips, mn10300, parisc, powerpc, s390, sh, sparc, x86). > > And kernel also already has prepared a default effective implementation > for the architectures which is unwilling to implement it by themselves > (e.g. arm64, c6x, h8300, hexagon, m32r, metag, microblaze, openrisc, > score, tile, um, unicore32, xtensa). > > So need get rid of 'CONFIG_BUG', and let it always enabled everywhere. This looks like the right way to handle this to me. If the BUG annotations are too big and not needed they should simply be deleted from the code base. Disabling CONFIG_BUG which removes the BUG annotations from the binaries without modifying the source code seems like the wrong approach. Acked-by: "Eric W. Biederman"