From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIjXA-0008It-1c for qemu-devel@nongnu.org; Thu, 21 Mar 2013 13:44:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIjX8-0002Tf-Mi for qemu-devel@nongnu.org; Thu, 21 Mar 2013 13:44:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22748) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIjX8-0002SY-Fo for qemu-devel@nongnu.org; Thu, 21 Mar 2013 13:44:10 -0400 From: Juan Quintela In-Reply-To: <20130321162912.GH1925@redhat.com> (Michael S. Tsirkin's message of "Thu, 21 Mar 2013 18:29:12 +0200") References: <1363881940-27505-1-git-send-email-owasserm@redhat.com> <1363881940-27505-10-git-send-email-owasserm@redhat.com> <20130321161608.GE1925@redhat.com> <514B34FE.6010901@redhat.com> <20130321162912.GH1925@redhat.com> Date: Thu, 21 Mar 2013 18:44:14 +0100 Message-ID: <877gl0ps0h.fsf@elfo.elfo> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v3 9/9] coalesce adjacent iovecs Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Orit Wasserman , chegu_vinod@hp.com, qemu-devel@nongnu.org, pbonzini@redhat.com "Michael S. Tsirkin" wrote: > On Thu, Mar 21, 2013 at 06:27:42PM +0200, Orit Wasserman wrote: >> On 03/21/2013 06:16 PM, Michael S. Tsirkin wrote: >> > On Thu, Mar 21, 2013 at 06:05:40PM +0200, Orit Wasserman wrote: >> >> This way we send one big buffer instead of many small ones >> >> >> >> Signed-off-by: Orit Wasserman >> > >> > Why does this happen BTW? >> >> It happens in the last phase when we send the device state that >> consists of a lot >> bytes and int field that are written using qemu_put_byte/be16/... >> > > Confused I thought device_state does not use _nocopy? > My idea of using vmsplice relies exactly on this: > we can not splice device state ... As it is today, I am not sure that we can use vmsplice() because we are sending:
We can optimize at some pount to write a bigger/different header and sent a bunch of pages together, but just now we don't have that code. Later, Juan.