Re: [PATCHv2] virtio: Introduce vringh wrappers in virtio_config

From: Rusty Russell <rusty@rustcorp.com.au>
To: sjur@brendeland.net
Cc: Linus Walleij <linus.walleij@linaro.org>,
	mst@redhat.com, Erwan Yvin <erwan.yvin@stericsson.com>,
	virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCHv2] virtio: Introduce vringh wrappers in virtio_config
Date: Mon, 18 Mar 2013 19:22:37 +1030	[thread overview]
Message-ID: <877gl5rsx6.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CAJK669a40vtD8LN4uhJdqsoP6cuMq-fBgeJYT8A27PFOPDFZMQ@mail.gmail.com>

Sjur Brændeland <sjur@brendeland.net> writes:
> On Mon, Mar 18, 2013 at 12:29 AM, Ohad Ben-Cohen <ohad@wizery.com> wrote:
>> Hi Sjur,
>>
>> Sorry for the delay - just got back from you know where :)
>>
>> On Wed, Mar 13, 2013 at 12:12 PM, Sjur Brændeland <sjurbren@gmail.com> wrote:
>>>> From: Sjur Brændeland <sjur.brandeland@stericsson.com>
>>>>
>>>> Add wrappers for the host vrings to support loose
>>>> coupling between the virtio device and driver.
>>>>
>>>> A new struct vringh_config_ops with the functions
>>>> find_vrhs() and del_vrhs() is added to the virtio_device
>>>> struct. This enables virtio drivers to manage virtio
>>>> host rings without detailed knowledge of how the
>>>> vrings are created and deleted.
>>>>
>>>> The function vringh_notify() is added so vringh clients
>>>> can notify the other side that buffers are added to the
>>>> used-ring.
>>>>
>>>> Cc: Ohad Ben-Cohen <ohad@wizery.com>
>>>> Cc: Rusty Russell <rusty@rustcorp.com.au>
>>>> Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
>>>
>>> As you have been pushing for this wrapper, could you please
>>> add your Ack or Reviewed tag if you are happy with this patch?
>>
>> I am happy with this patch: the caif virtio driver is now decoupled
>> from remoteproc which I think is great. Thanks for doing it!
>>
>> To provide a Reviewed-by tag though I need to review it from a virtio
>> point of view, which I can try to do after I'll finish going through
>> my backlog of pending patches. Let me finish that pile of patches I
>> have, and if you or Rusty will still want me to provide a Reviewed-by
>> tag here I'll do it.
>
> Hi Rusty,
>
> Do you have what you need to apply this patch?
> Please, let me know if any further changes are needed.
> The informal ack above from Ohad is good enough for me :-)

I'm pretty happy, thanks.

Because there's so much churn, I've refreshed my "vringh" branch with
this in it.

So can you please check that branch works for you?

Thanks,
Rusty.
PS. Michael, you can see what I'm hacking on with vhost/net there too,
    though it's unfinished...
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization