From: ebiederm@xmission.com (Eric W. Biederman)
To: Rami Rosen <ramirose@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, shemminger@vyatta.com
Subject: Re: [RFC PATCH v2 net-next 2/2] bridge: remove NETIF_F_NETNS_LOCAL from bridge device features.
Date: Mon, 07 Jan 2013 01:20:44 -0800 [thread overview]
Message-ID: <877gnp73ir.fsf@xmission.com> (raw)
In-Reply-To: <1357543176-15352-3-git-send-email-ramirose@gmail.com> (Rami Rosen's message of "Mon, 7 Jan 2013 09:19:36 +0200")
Rami Rosen <ramirose@gmail.com> writes:
> There is no need for NETIF_F_NETNS_LOCAL for bridge device; this patch
> removes it.
At the very least add_del_if assumes are network devices are in the same
network namespace as the bridge. So removing NETIF_F_NETNS_LOCAL is not
safe.
Eric
next prev parent reply other threads:[~2013-01-07 9:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 7:19 [RFC PATCH v2 net-next 0/2] Remove NETIF_F_NETNS_LOCAL from software devices Rami Rosen
2013-01-07 7:19 ` [RFC PATCH v2 net-next 1/2] ppp: remove NETIF_F_NETNS_LOCAL from ppp device features Rami Rosen
2013-01-07 9:16 ` Eric W. Biederman
2013-01-07 7:19 ` [RFC PATCH v2 net-next 2/2] bridge: remove NETIF_F_NETNS_LOCAL from bridge " Rami Rosen
2013-01-07 9:20 ` Eric W. Biederman [this message]
2013-01-07 9:25 ` [RFC PATCH v2 net-next 0/2] Remove NETIF_F_NETNS_LOCAL from software devices Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gnp73ir.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ramirose@gmail.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.