From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCHv8 0/3]virtio_console: Add rproc_serial driver Date: Mon, 05 Nov 2012 09:11:45 +1030 Message-ID: <877gq1yora.fsf@rustcorp.com.au> References: <1351587113-2566-1-git-send-email-sjur@brendeland.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1351587113-2566-1-git-send-email-sjur@brendeland.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Sjur =?utf-8?Q?Br=C3=A6ndeland?= Cc: "Michael S. Tsirkin" , Linus Walleij , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Masami Hiramatsu , Amit Shah , Sjur =?utf-8?Q?Br=C3=A6ndeland?= List-Id: virtualization@lists.linuxfoundation.org U2p1ciBCcsOmbmRlbGFuZCA8c2p1ckBicmVuZGVsYW5kLm5ldD4gd3JpdGVzOgoKPiBGcm9tOiBT anVyIEJyw6ZuZGVsYW5kIDxzanVyLmJyYW5kZWxhbmRAc3Rlcmljc3Nvbi5jb20+Cj4KPiBUaGlz IHBhdGNoLXNldCBpbnRyb2R1Y2VzIGEgbmV3IHZpcnRpbyB0eXBlICJycHJvY19zZXJpYWwiIGZv ciBjb21tdW5pY2F0aW5nCj4gd2l0aCByZW1vdGUgcHJvY2Vzc29ycyBvdmVyIHNoYXJlZCBtZW1v cnkuIFRoZSBkcml2ZXIgZGVwZW5kcyBvbiB0aGUKPiB0aGUgcmVtb3RlcHJvYyBmcmFtZXdvcmsu IEFzIHByZXBhcmF0aW9uIGZvciBpbnRyb2R1Y2luZyAicnByb2Nfc2VyaWFsIgo+IEkndmUgZG9u ZSBhIHJlZmFjdG9yaW5nIG9mIHRoZSB0cmFuc21pdCBidWZmZXIgaGFuZGxpbmcuCj4KPiBDaGFu Z2VzIHNpbmNlIHY3Ogo+IC0gUmViYXNlZCB0byB2aXJ0aW8tbmV4dCBicmFuY2guCj4gLSBSZW1v dmVkIGV4dHJhIGFkZGVkIGxpbmVzLgo+IC0gUmVtb3ZlZCBzdXBlcmZsdW91cyBjaGVja3MgYmVm b3JlIGNhbGxpbmcgcmVjbGFpbV9kbWFfYnVmcygpLgo+IC0gUnVzdHkgcmFpc2VkIHNvbWUgcXVl c3Rpb24gcmVnYXJkaW5nIGdhcmJhZ2UgY29sbGVjdGlvbiBvZiB0aGUKPiAgIG91dC12cSwgc28g SSBtb3ZlZCB0aGlzIGludG8gYSBzZXBhcmF0ZSBwYXRjaC4KCk9LLCBJJ20gbm90IHN1cmUgdGhh dCBXQVJOX09OIHdvbid0IGZpcmUsIGJ1dCB0aGF0J3Mgbm90IGFsbCB0aGF0Cmhhcm1mdWwuCgpB cHBsaWVkLApSdXN0eS4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KVmlydHVhbGl6YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxp bnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWls bWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752944Ab2KDXrt (ORCPT ); Sun, 4 Nov 2012 18:47:49 -0500 Received: from ozlabs.org ([203.10.76.45]:38602 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752002Ab2KDXrp convert rfc822-to-8bit (ORCPT ); Sun, 4 Nov 2012 18:47:45 -0500 From: Rusty Russell To: Sjur =?utf-8?Q?Br=C3=A6ndeland?= Cc: "Michael S. Tsirkin" , Amit Shah , Linus Walleij , Masami Hiramatsu , Ohad Ben-Cohen , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, sjurbren@gmail.com, Sjur =?utf-8?Q?Br=C3=A6ndeland?= Subject: Re: [PATCHv8 0/3]virtio_console: Add rproc_serial driver In-Reply-To: <1351587113-2566-1-git-send-email-sjur@brendeland.net> References: <1351587113-2566-1-git-send-email-sjur@brendeland.net> User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/23.4.1 (i686-pc-linux-gnu) Date: Mon, 05 Nov 2012 09:11:45 +1030 Message-ID: <877gq1yora.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sjur Brændeland writes: > From: Sjur Brændeland > > This patch-set introduces a new virtio type "rproc_serial" for communicating > with remote processors over shared memory. The driver depends on the > the remoteproc framework. As preparation for introducing "rproc_serial" > I've done a refactoring of the transmit buffer handling. > > Changes since v7: > - Rebased to virtio-next branch. > - Removed extra added lines. > - Removed superfluous checks before calling reclaim_dma_bufs(). > - Rusty raised some question regarding garbage collection of the > out-vq, so I moved this into a separate patch. OK, I'm not sure that WARN_ON won't fire, but that's not all that harmful. Applied, Rusty.