From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Korsgaard Subject: Re: [PATCH 1/4] net: davinci_mdio: Fix typo mistake in calling runtime-pm api Date: Tue, 30 Oct 2012 22:33:53 +0100 Message-ID: <877gq7hcfy.fsf@macbook.be.48ers.dk> References: <1351498881-32482-1-git-send-email-hvaibhav@ti.com> <1351498881-32482-3-git-send-email-hvaibhav@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <1351498881-32482-3-git-send-email-hvaibhav@ti.com> (Vaibhav Hiremath's message of "Mon, 29 Oct 2012 13:51:18 +0530") Sender: netdev-owner@vger.kernel.org To: Vaibhav Hiremath Cc: netdev@vger.kernel.org, paul@pwsan.com, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Mugunthan V N , Richard Cochran List-Id: linux-omap@vger.kernel.org >>>>> "Vaibhav" == Vaibhav Hiremath writes: Vaibhav> By mistake (most likely a copy-paste), instead of pm_runtime_get_sync() Vaibhav> api, driver is calling pm_runtime_put_sync() api in resume callback Vaibhav> function. The bug was introduced by commit id (ae2c07aaf74: Vaibhav> davinci_mdio: runtime PM support). Vaibhav> Now, the reason why it didn't impact functionality is, the patch has Vaibhav> been tested on AM335x-EVM and BeagleBone platform while submitting; Vaibhav> and in case of AM335x the MDIO driver doesn't control the module Vaibhav> enable/disable part, which is handled by CPSW driver. Vaibhav> Signed-off-by: Vaibhav Hiremath Vaibhav> Cc: Mugunthan V N Vaibhav> Cc: Richard Cochran Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard From mboxrd@z Thu Jan 1 00:00:00 1970 From: jacmet@sunsite.dk (Peter Korsgaard) Date: Tue, 30 Oct 2012 22:33:53 +0100 Subject: [PATCH 1/4] net: davinci_mdio: Fix typo mistake in calling runtime-pm api In-Reply-To: <1351498881-32482-3-git-send-email-hvaibhav@ti.com> (Vaibhav Hiremath's message of "Mon, 29 Oct 2012 13:51:18 +0530") References: <1351498881-32482-1-git-send-email-hvaibhav@ti.com> <1351498881-32482-3-git-send-email-hvaibhav@ti.com> Message-ID: <877gq7hcfy.fsf@macbook.be.48ers.dk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org >>>>> "Vaibhav" == Vaibhav Hiremath writes: Vaibhav> By mistake (most likely a copy-paste), instead of pm_runtime_get_sync() Vaibhav> api, driver is calling pm_runtime_put_sync() api in resume callback Vaibhav> function. The bug was introduced by commit id (ae2c07aaf74: Vaibhav> davinci_mdio: runtime PM support). Vaibhav> Now, the reason why it didn't impact functionality is, the patch has Vaibhav> been tested on AM335x-EVM and BeagleBone platform while submitting; Vaibhav> and in case of AM335x the MDIO driver doesn't control the module Vaibhav> enable/disable part, which is handled by CPSW driver. Vaibhav> Signed-off-by: Vaibhav Hiremath Vaibhav> Cc: Mugunthan V N Vaibhav> Cc: Richard Cochran Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard