From mboxrd@z Thu Jan  1 00:00:00 1970
From: ebiederm@xmission.com (Eric W. Biederman)
Subject: Re: [PATCH] fs: Introducing Lanyard Filesystem
Date: Thu, 23 Aug 2012 10:29:45 -0700
Message-ID: <877gspms8m.fsf@xmission.com>
References: <1345333117-2826-1-git-send-email-mail@danrl.de>
Mime-Version: 1.0
Content-Type: text/plain
Cc: linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
	akpm@linux-foundation.org, chaosman@ontika.net, muthur@gmail.com,
	kerolasa@iki.fi, linux-kernel@vger.kernel.org
To: Dan Luedtke <mail@danrl.de>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1345333117-2826-1-git-send-email-mail@danrl.de> (Dan Luedtke's
	message of "Sun, 19 Aug 2012 01:38:37 +0200")
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

Dan Luedtke <mail@danrl.de> writes:

> +/**
> + * struct lanyfs_opts - mount options
> + * @uid:			userid of all files and directories
> + * @gid:			grouid of all files and direcotries
> + * @dmask:			directory mask
> + * @fmask:			file mask
> + * @discard:			issue discard requests on block freeing
> + * @flush:			force instant writing of changed data
> + */
> +struct lanyfs_opts {
> +	uid_t			uid;
> +	gid_t			gid;
A small nit.  Those above two lines should be:
	kuid_t			uid;
	kgid_t			gid;
> +	unsigned int		dmask;
> +	unsigned int		fmask;
> +	unsigned int		discard:1,
> +				flush:1;
> +};

Eric