From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwymL-0003Pm-8j for qemu-devel@nongnu.org; Thu, 02 Aug 2012 13:01:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwymG-0004Yo-FB for qemu-devel@nongnu.org; Thu, 02 Aug 2012 13:01:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwymG-0004Yj-7Q for qemu-devel@nongnu.org; Thu, 02 Aug 2012 13:01:36 -0400 From: Markus Armbruster References: <1343869374-23417-1-git-send-email-lcapitulino@redhat.com> <1343869374-23417-28-git-send-email-lcapitulino@redhat.com> Date: Thu, 02 Aug 2012 19:01:32 +0200 In-Reply-To: <1343869374-23417-28-git-send-email-lcapitulino@redhat.com> (Luiz Capitulino's message of "Wed, 1 Aug 2012 22:02:47 -0300") Message-ID: <877gthtehf.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 27/34] qerror: add proper ErrorClass value for QERR_ macros List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, pbonzini@redhat.com, eblake@redhat.com Luiz Capitulino writes: > This commit replaces the place holder value for the ErrorClass > argument with a proper ErrorClass value for all QERR_ macros. > > All current errors are mapped to GenericError, except for errors > CommandNotFound, DeviceNotActive, DeviceNotFound, KVMMissingCap and > MigrationExpected, which are maintained as they are today. > > Signed-off-by: Luiz Capitulino > --- > qerror.h | 140 +++++++++++++++++++++++++++++++-------------------------------- > 1 file changed, 70 insertions(+), 70 deletions(-) > > diff --git a/qerror.h b/qerror.h > index bcc93f8..94346cb 100644 > --- a/qerror.h > +++ b/qerror.h > @@ -45,214 +45,214 @@ char *qerror_format(const char *fmt, QDict *error); > * Use scripts/check-qerror.sh to check. > */ > #define QERR_ADD_CLIENT_FAILED \ > - -1, "{ 'class': 'AddClientFailed', 'data': {} }" > + ERROR_CLASS_GENERIC_ERROR, "{ 'class': 'AddClientFailed', 'data': {} }" Now we have two different things called "class" here. Ugly. But only until PATCH 31 gets rid of the old one. Okay. [...]