From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34249)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Ss9sE-0003je-4e
	for qemu-devel@nongnu.org; Fri, 20 Jul 2012 05:51:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Ss9sC-0001E5-SC
	for qemu-devel@nongnu.org; Fri, 20 Jul 2012 05:51:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44294)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Ss9sC-0001Dx-KN
	for qemu-devel@nongnu.org; Fri, 20 Jul 2012 05:51:48 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1342617545-9261-1-git-send-email-liwanp@linux.vnet.ibm.com>
	<1342617545-9261-5-git-send-email-liwanp@linux.vnet.ibm.com>
	<87bojdw2tx.fsf@blackfin.pond.sub.org> <87a9yvcxd1.fsf@codemonkey.ws>
Date: Fri, 20 Jul 2012 11:51:29 +0200
In-Reply-To: <87a9yvcxd1.fsf@codemonkey.ws> (Anthony Liguori's message of
	"Thu, 19 Jul 2012 15:24:58 -0500")
Message-ID: <877gtydala.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v4 4/5] prepare to create HPET,
	RTC and i8254 through composition
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Ramachandra Pai <pair@us.ibm.com>, Gavin Shan <shangw@linux.vnet.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Liu Ping Fan <kernelfans@gmail.com>, Blue Swirl <blauwirbel@gmail.com>, Stefan Weil <weil@mail.berlios.de>, Avi Kivity <avi@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Wanpeng Li <liwanp@linux.vnet.ibm.com>

Anthony Liguori <aliguori@us.ibm.com> writes:

> Markus Armbruster <armbru@redhat.com> writes:
>
>> Wanpeng Li <liwanp@linux.vnet.ibm.com> writes:
>>
>>> [CCing ML]
>>>  
>>>  From: Anthony Liguori <aliguori@us.ibm.com>
>>>
>>> The HPET usually sits on the LPC bus (which replaces ISA in modern systems).
>>> It's sometimes a dedicated chip but can certain co-exist in a Super IO chip.
>>> I think in terms of where it would live in this hypothetical device model,
>>> putting it in the PIIX is rational.
>>
>> Could you explain briefly why you have to move struct definitions from
>> .c to .h?
>
> This patch shouldn't be in this series.  The reason to do this is so
> that the PIIX3 can do composition and have the HPET/PIT as child
> devices.  But that isn't in this series so having this patch isn't
> useful.

Let's drop it then for now.