From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754068Ab2GIVe7 (ORCPT ); Mon, 9 Jul 2012 17:34:59 -0400 Received: from mail.parknet.co.jp ([210.171.160.6]:43128 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752292Ab2GIVe6 (ORCPT ); Mon, 9 Jul 2012 17:34:58 -0400 From: OGAWA Hirofumi To: "Steven J. Magnani" Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] fat (exportfs): reconnect file handles to evicted inodes/dentries References: <1341342576-15394-1-git-send-email-steve@digidescorp.com> <1341342576-15394-3-git-send-email-steve@digidescorp.com> <87pq8bokcp.fsf@devron.myhome.or.jp> <1341606824.2214.14.camel@iscandar.digidescorp.com> <871ukobntl.fsf@devron.myhome.or.jp> <1341623782.2021.9.camel@iscandar> <87wr2g9kh3.fsf@devron.myhome.or.jp> <1341679286.2435.12.camel@iscandar> <87zk7bo6aq.fsf@devron.myhome.or.jp> <1341835422.2215.6.camel@iscandar.digidescorp.com> <87sjd1nj7s.fsf@devron.myhome.or.jp> <1341845277.2215.10.camel@iscandar.digidescorp.com> <87obnooqz7.fsf@devron.myhome.or.jp> <1341851223.2215.22.camel@iscandar.digidescorp.com> <1341853758.2215.34.camel@iscandar.digidescorp.com> <87bojooinr.fsf@devron.myhome.or.jp> <1341865572.31078.2.camel@iscandar.digidescorp.com> Date: Tue, 10 Jul 2012 06:34:53 +0900 In-Reply-To: <1341865572.31078.2.camel@iscandar.digidescorp.com> (Steven J. Magnani's message of "Mon, 09 Jul 2012 15:26:12 -0500") Message-ID: <877gucobya.fsf@devron.myhome.or.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Steven J. Magnani" writes: >> Ah, i_ino. I was talking about i_pos. Well, so, what happens if the >> child was renamed to other parent on NFS server machine (not via nfs >> client)? The file handle would be including the old i_ino, and the old >> i_ino on file handle is still vaild as old parent. So, it returns the >> wrong parent? > > Yes, but I believe exportfs_decode_fh() handles that case: > > /* > * Now that we've got both a well-connected parent and a > * dentry for the inode we're after, make sure that our > * inode is actually connected to the parent. > */ > > > Really, the FAT NFS code will pretty much parallel that of ext2. Hm, not really, if the file handle is including parent ino. ext2 will get the latest parent ino, because it checks parent of inode of file handle. But if the file handle is including parent ino and we believe it is parent, I think NFS server can be return the old parent. The difference is the result of ->get_parent(). -- OGAWA Hirofumi