From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Rusty Russell To: Greg KH , Sasha Levin Cc: Tim Abbott , stable@vger.kernel.org Subject: Re: Patch Upstream: module: Remove module size limit In-Reply-To: <20120328233252.GA16375@kroah.com> References: <20120328220121.108CF26EF@git.kroah.org> <20120328224112.GA10691@kroah.com> <20120328230952.GA6419@kroah.com> <20120328233252.GA16375@kroah.com> Date: Thu, 29 Mar 2012 15:25:20 +1030 Message-ID: <877gy4ypjb.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-ID: On Wed, 28 Mar 2012 16:32:52 -0700, Greg KH wr= ote: > On Thu, Mar 29, 2012 at 01:22:23AM +0200, Sasha Levin wrote: > > On Thu, Mar 29, 2012 at 1:09 AM, Greg KH w= rote: > > > On Thu, Mar 29, 2012 at 12:57:47AM +0200, Sasha Levin wrote: > > >> On Thu, Mar 29, 2012 at 12:41 AM, Greg KH wrote: > > >> > For the patch below, what are the "real world use cases" that would > > >> > cause this to be needed in the stable kernel trees? =C2=A0Is there= an > > >> > in-kernel module that is affected by this limitation? > > >> > > >> There are no in-kernel modules which are affected, the "real world" > > >> scenario is debug modules generated by Ksplice. > > > > > > So why is this needed for the stable kernels? =C2=A0This really looks= like a > > > feature not a bugfix to me, how about you? > >=20 > > I guess it depends on whether you consider the inability to load > > modules bigger than 64mb as a bug or not. >=20 > As there is no in-kernel user with this problem, no, I don't think it's > a bug that meets the rules documented in > Documentation/stable_kernel_rules.txt, do you? Your call, but it has been my policy to support ksplice, such as making sure we export symbols it needs. And this really is a low-risk change. Thanks, Rusty. --=20 How could I marry someone with more hair than me? http://baldalex.org