All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: "Andreas Bießmann" <andreas@biessmann.de>
Cc: "Andreas Bießmann" <andreas@biessmann.de>,
	linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
	"Jochen Friedrich" <jochen@scram.de>,
	"Samuel Ortiz" <sameo@linux.intel.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>
Subject: Re: [PATCH] mod/file2alias: make modpost compile on darwin again
Date: Fri, 24 Feb 2012 14:34:59 +1030	[thread overview]
Message-ID: <877gzc511w.fsf@rustcorp.com.au> (raw)
In-Reply-To: <4F45DC99.1050405@biessmann.de>

On Thu, 23 Feb 2012 07:28:41 +0100, Andreas Bießmann <andreas@biessmann.de> wrote:
> > Oh, and checkpatch.pl is wrong, the code was fine.
> 
> Sorry for that. I was running checkpatch.pl as dutiful patch submitter
> and that complained.

In the Olden Days, we could easily spot code which needed auditing
simply by looking at the (lack of) coding style.  But then someone
decided that the most important attribute of good code was the nature of
the whitespace within it.  And they wrote a tool.

For a while, this made it really hard for us maintainers to tell which
incoming patches we should actually read!  Fortunately, the
Anti-whitespace crusaders have come full circle: we can now tell newbie
coders by the fact that they obey checkpatch.pl.

> Should I provide another version with 'checkpatch' adoptions changed
> back?

Please :)

Thanks,
Rusty.

  reply	other threads:[~2012-02-24  4:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-22 21:55 [PATCH] mod/file2alias: make modpost compile on darwin again Andreas Bießmann
2012-02-22 23:08 ` Rusty Russell
2012-02-23  6:28   ` Andreas Bießmann
2012-02-24  4:04     ` Rusty Russell [this message]
2012-02-24  7:23 ` [PATCH v2] " Andreas Bießmann
2012-02-25  3:51   ` Rusty Russell
2012-02-26 16:27   ` Bernhard Walle
2012-02-27  0:03     ` [PULL] modpost fix for cross-compiling Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877gzc511w.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=andreas@biessmann.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jochen@scram.de \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.