From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH] gpio: omap: be more aggressive with pm_runtime Date: Wed, 08 Feb 2012 16:01:42 -0800 Message-ID: <877gzwyivt.fsf@ti.com> References: <1328707614-20146-1-git-send-email-balbi@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog118.obsmtp.com ([74.125.149.244]:36577 "EHLO na3sys009aog118.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757706Ab2BIABp (ORCPT ); Wed, 8 Feb 2012 19:01:45 -0500 Received: by mail-pw0-f41.google.com with SMTP id wz17so1259653pbc.14 for ; Wed, 08 Feb 2012 16:01:44 -0800 (PST) In-Reply-To: <1328707614-20146-1-git-send-email-balbi@ti.com> (Felipe Balbi's message of "Wed, 8 Feb 2012 15:26:54 +0200") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Balbi Cc: Linux OMAP Mailing List , Linux ARM Kernel Mailing List , Tony Lindgren , grant.likely@secretlab.ca, linus.walleij@stericsson.com, tarun.kanti@ti.com Felipe Balbi writes: > try to keep gpio block suspended as much as possible. > > Tested with pandaboard and a sysfs exported gpio. > > Signed-off-by: Felipe Balbi > --- Looks like you need a few more get/puts around other places where registers are accessed. It currently causes a boot crash on OMAP3 in _set_gpio_triggering(). Did you test GPIO wakeups? both IO ring wakeups and GPIO module-level wakeups? Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Wed, 08 Feb 2012 16:01:42 -0800 Subject: [PATCH] gpio: omap: be more aggressive with pm_runtime In-Reply-To: <1328707614-20146-1-git-send-email-balbi@ti.com> (Felipe Balbi's message of "Wed, 8 Feb 2012 15:26:54 +0200") References: <1328707614-20146-1-git-send-email-balbi@ti.com> Message-ID: <877gzwyivt.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Felipe Balbi writes: > try to keep gpio block suspended as much as possible. > > Tested with pandaboard and a sysfs exported gpio. > > Signed-off-by: Felipe Balbi > --- Looks like you need a few more get/puts around other places where registers are accessed. It currently causes a boot crash on OMAP3 in _set_gpio_triggering(). Did you test GPIO wakeups? both IO ring wakeups and GPIO module-level wakeups? Kevin